Port AutoFormat into content model AutoFormatPlugin #2552
Conversation
…rosoft/roosterjs into u/juliaroldi/auto-hypen-port
juliaroldi
changed the title
juliaroldi
requested review from
flyingbee2012,
BryanValverdeU,
JiuqingSong,
ianeli1,
vinguyen12 and
Andres-CT98
|
In old plugin, auto hyphen happens when we type anything after "--", but here it only happens when we type space. Is that expected? |
| * @internal | ||
| */ | ||
| export function transformHyphen(editor: IEditor) { | ||
| editor.formatContentModel((model, context) => { |
There was a problem hiding this comment.
A little concerned about we call formatContentModel so many times for a single input. Can we just merge them into a single call?
There was a problem hiding this comment.
I think we can merge them. I'll create a function to format the segment before the marker that can be common to autoformat and markdown.
| */ | ||
| export function transformHyphen(editor: IEditor) { | ||
| editor.formatContentModel((model, context) => { | ||
| const selectedAndParagraphs = getSelectedSegmentsAndParagraphs( |
There was a problem hiding this comment.
Then this result can also be shared.
|
I see, sounds good. |
…rosoft/roosterjs into u/juliaroldi/auto-hypen-port
| /** | ||
| * @internal | ||
| */ | ||
| export function formatTextSegmentBeforeSelectionMarker( |
| keyboardListTrigger(editor, autoBullet, autoNumbering); | ||
| if (autoLink) { | ||
| createLinkAfterSpace(editor); | ||
| } | ||
| if (autoHyphen) { | ||
| transformHyphen(editor); | ||
| } |
There was a problem hiding this comment.
Can we call formatTextSegmentBeforeSelectionMarker here, then call keyboardListTrigger, createLinkAfterSpace, transformHyphen inside it? So that we only need to format with Content Model once.
There was a problem hiding this comment.
I created a separated PR: #2557 for it, since I needed to change a lot of files.
AutoFormat plugin is responsible for formatting two dashes into a hyphen. This feature was ported into content model AutoFormatPlugin.
