Set isSelected to false for formatHolder of list item #2540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JiuqingSong
changed the title
JiuqingSong
requested review from
juliaroldi,
Andres-CT98,
BryanValverdeU,
flyingbee2012,
ianeli1 and
vinguyen12
juliaroldi
approved these changes
Mar 28, 2024
juliaroldi
reviewed
Mar 28, 2024
| @@ -15,14 +15,18 @@ export function createListItem( | |||
| levels: ContentModelListLevel[], | |||
| format?: ContentModelSegmentFormat | |||
| ): ContentModelListItem { | |||
| const formatHolder = createSelectionMarker(format); | |||
|
|
|||
| formatHolder.isSelected = false; | |||
There was a problem hiding this comment.
if the marker is in the list item, should it be true?
There was a problem hiding this comment.
Actually we never read that value, so it can be false.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we allow SelectionMarker to have isSelected: false, we can set this false value to formatHolder under list item to better match its meaning.