Leverage DOMInsertPoint, remove posContainer/offset #2538
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In old editor we have a
NodePosition
interface which stores a node-offset pair. In new editor I removed it since we should focus on using Content Model to represent selection.However, now I realized that in some places it is still continent to have such an interface, so I added an interface
DOMInsertPoint
in an earlier change. Now we can leverage this interface in several places, such asThis is a refactor only, no logic change