Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leverage DOMInsertPoint, remove posContainer/offset #2538

Merged
merged 4 commits into from
Mar 28, 2024

Conversation

JiuqingSong
Copy link
Collaborator

@JiuqingSong JiuqingSong commented Mar 27, 2024

In old editor we have a NodePosition interface which stores a node-offset pair. In new editor I removed it since we should focus on using Content Model to represent selection.

However, now I realized that in some places it is still continent to have such an interface, so I added an interface DOMInsertPoint in an earlier change. Now we can leverage this interface in several places, such as

  • UndoPluginState for the auto complete insert point
  • FormatPluginState for the pending format insert point

This is a refactor only, no logic change

@JiuqingSong JiuqingSong merged commit ee44e54 into master Mar 28, 2024
7 checks passed
@JiuqingSong JiuqingSong deleted the u/jisong/leveragedominsertpoint branch March 28, 2024 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants