Skip to content

Commit

Permalink
Bump version to 9.3.1: Hot fix #2633 (#2635)
Browse files Browse the repository at this point in the history
* Fix #2633 `scrollCaretIntoView` causes unexpected scroll (#2634)

* Fix #2633

* add comment

* 9.3.1: Hot fix #2633
  • Loading branch information
JiuqingSong authored May 15, 2024
1 parent 1822d18 commit 5638d0e
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ export function mergePasteContent(
{
changeSource: ChangeSource.Paste,
getChangeData: () => clipboardData,
scrollCaretIntoView: true,
scrollCaretIntoView: false, // TODO #2633: Make a full fix to the scroll behavior
apiName: 'paste',
}
);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ export function keyboardDelete(editor: IEditor, rawEvent: KeyboardEvent) {
rawEvent,
changeSource: ChangeSource.Keyboard,
getChangeData: () => rawEvent.which,
scrollCaretIntoView: true,
scrollCaretIntoView: false, // TODO #2633: Make a full fix to the scroll behavior
apiName: rawEvent.key == 'Delete' ? 'handleDeleteKey' : 'handleBackspaceKey',
}
);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ export function keyboardInput(editor: IEditor, rawEvent: KeyboardEvent) {
}
},
{
scrollCaretIntoView: true,
scrollCaretIntoView: false, // TODO #2633: Make a full fix to the scroll behavior
rawEvent,
}
);
Expand Down
2 changes: 1 addition & 1 deletion versions.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"legacy": "8.62.0",
"react": "8.56.0",
"main": "9.3.0",
"main": "9.3.1",
"legacyAdapter": "8.62.0"
}

0 comments on commit 5638d0e

Please sign in to comment.