Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(web-storage): migrate away from deprecated ReactModuleInfo constructor #3434

Merged
merged 2 commits into from
Dec 2, 2024
Merged

fix(web-storage): migrate away from deprecated ReactModuleInfo constructor #3434

merged 2 commits into from
Dec 2, 2024

Conversation

tido64
Copy link
Member

@tido64 tido64 commented Nov 29, 2024

Description

Deprecated ReactModuleInfo constructor was recently removed: facebook/react-native@aec7a66

Failed in RNTA: https://github.com/microsoft/react-native-test-app/actions/runs/12078771069/job/33683653941

Test plan

In RNTA:

npm run set-react-version nightly
yarn clean
yarn

# Manually patch `node_modules/@react-native-webapis/web-storage/android/src/main/java/org/reactnativewebapis/webstorage/WebStoragePackage.kt`

cd example
yarn android

@tido64 tido64 requested a review from Saadnajmi November 29, 2024 14:08
@tido64 tido64 mentioned this pull request Nov 29, 2024
Open
24 tasks
@github-actions github-actions bot added feature: webapis This is related to the experimental effort around WebAPIs for RN feature: sdk This is related to 1RN SDK labels Nov 29, 2024
@tido64 tido64 force-pushed the tido/android/deprecated-rmi-constr branch from 368adcd to d84c93b Compare November 29, 2024 14:16
@tido64 tido64 merged commit c88c843 into main Dec 2, 2024
11 checks passed
@tido64 tido64 deleted the tido/android/deprecated-rmi-constr branch December 2, 2024 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Saadnajmi Saadnajmi Saadnajmi approved these changes

@acoates-ms acoates-ms Awaiting requested review from acoates-ms acoates-ms is a code owner

@JasonVMo JasonVMo Awaiting requested review from JasonVMo JasonVMo is a code owner

Assignees
No one assigned
Labels
feature: sdk This is related to 1RN SDK feature: webapis This is related to the experimental effort around WebAPIs for RN
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tido64 @Saadnajmi