Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(react-native-host): fix building with statically linked frameworks #3413

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

tido64
Copy link
Member

@tido64 tido64 commented Nov 7, 2024

Description

Fixed building with statically linked frameworks.

Test plan

  1. Enable static frameworks:
    diff --git a/packages/test-app/ios/Podfile b/packages/test-app/ios/Podfile
    index 151b7586..7951b717 100644
    --- a/packages/test-app/ios/Podfile
    +++ b/packages/test-app/ios/Podfile
    @@ -1,5 +1,7 @@
     platform :ios, '14.0'
    
    +use_frameworks! :linkage => :static
    +
     require_relative '../node_modules/react-native-test-app/test_app'
    
     workspace 'SampleCrossApp.xcworkspace'
  2. Build the iOS app:
    yarn
    yarn nx build @rnx-kit/test-app
    cd packages/test-app
    pod install --project-directory=ios
    yarn ios
    

@github-actions github-actions bot added the feature: sdk This is related to 1RN SDK label Nov 7, 2024
@tido64 tido64 force-pushed the tido/fix-use_frameworks branch from 394b1d2 to a6d8fca Compare November 13, 2024 11:13
@tido64 tido64 marked this pull request as ready for review November 13, 2024 11:13
@tido64 tido64 enabled auto-merge (squash) November 13, 2024 11:13
@tido64 tido64 disabled auto-merge November 13, 2024 11:13
@tido64 tido64 merged commit b763270 into main Nov 13, 2024
12 checks passed
@tido64 tido64 deleted the tido/fix-use_frameworks branch November 13, 2024 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature: sdk This is related to 1RN SDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants