Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(third-party-notices): move Commander config from rnx-cli #3337

Merged
merged 1 commit into from
Sep 10, 2024

Conversation

tido64
Copy link
Member

@tido64 tido64 commented Sep 9, 2024

Description

Moved Commander config from @rnx-kit/cli to @rnx-kit/third-party-notices and resynced all flags.

Unfortunately, this means that if users were using the rnx-write-third-party-notices command before, they might have to adjust their flags when upgrading to this version. Hence, this is a breaking change for @rnx-kit/cli.

Test plan

cd packages/test-app
yarn build --dependencies
yarn rnx write-third-party-notices --help

Expected output:

Usage: rnx-cli write-third-party-notices [options]

Writes third party notices based on the given bundle

Options:
  --root-path <path>          The root of the repo to start resolving modules from (default: "/~/packages/test-app")
  --source-map-file <path>    The source map file to generate license contents for
  --json                      Output license information as a JSON
  --output-file <path>        The output file to write the license file to
  --ignore-scopes <string>    npm scopes to ignore and not emit license information for
  --ignore-modules <string>   Modules (JS packages) to not emit license information for
  --preamble-text <string>    A list of lines to prepend at the start of the generated license file
  --additional-text <string>  A list of lines to append at the end of the generated license file
  --full-license-text         Include full license text in the JSON output
  -h, --help                  display help for command

@tido64 tido64 requested a review from dannyvv September 9, 2024 09:42
@github-actions github-actions bot added feature: third party notices This is related to Third Party Notices feature: cli This is related to CLI labels Sep 9, 2024
Base automatically changed from tido/align-deps/commander-compat to main September 10, 2024 15:03
@tido64 tido64 force-pushed the tido/tpn/commander-compat branch from d93f873 to 63654fa Compare September 10, 2024 15:04
@tido64 tido64 marked this pull request as ready for review September 10, 2024 15:06
@tido64 tido64 requested a review from JasonVMo as a code owner September 10, 2024 15:06
@tido64 tido64 force-pushed the tido/tpn/commander-compat branch from 63654fa to 035da89 Compare September 10, 2024 18:04
@tido64 tido64 enabled auto-merge (squash) September 10, 2024 18:05
@tido64 tido64 merged commit 46cf8a7 into main Sep 10, 2024
10 checks passed
@tido64 tido64 deleted the tido/tpn/commander-compat branch September 10, 2024 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature: cli This is related to CLI feature: third party notices This is related to Third Party Notices
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants