Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): print the command being invoked during build #3325

Merged
merged 1 commit into from
Sep 3, 2024

Conversation

tido64
Copy link
Member

@tido64 tido64 commented Sep 2, 2024

Description

Print the command being invoked during build.

Test plan

Patch:

diff --git a/packages/cli/src/index.ts b/packages/cli/src/index.ts
index 00b83a26..e89dffee 100644
--- a/packages/cli/src/index.ts
+++ b/packages/cli/src/index.ts
@@ -4,12 +4,14 @@ import { rnxBundleCommand } from "./bundle";
 import { rnxCleanCommand } from "./clean";
 import { rnxCopyAssetsCommand } from "./copy-assets";
 import { rnxRamBundleCommand } from "./ram-bundle";
+import { rnxRunCommand } from "./run";
 import { rnxStartCommand } from "./start";
 import { rnxTestCommand } from "./test";
 import { rnxWriteThirdPartyNoticesCommand } from "./write-third-party-notices";

 export const reactNativeConfig = {
   commands: [
+    rnxRunCommand,
     rnxBundleCommand,
     rnxRamBundleCommand,
     rnxStartCommand,

Build:

cd packages/test-app
yarn build --dependencies
yarn rnx run --platform ios

Example output:

ℹ Multiple schemes were found; picking the first one: ReactTestApp, SampleCrossApp
ℹ If this is wrong, specify another scheme with `--scheme`
ℹ Command: xcodebuild -workspace /~/packages/test-app/ios/SampleCrossApp.xcworkspace -scheme ReactTestApp -configuration Debug -derivedDataPath /~/packages/test-app/ios/DerivedData -sdk iphonesimulator -destination generic/platform=iOS Simulator CODE_SIGNING_ALLOWED=NO COMPILER_INDEX_STORE_ENABLE=NO build
⠇ Building...

@tido64 tido64 requested a review from Saadnajmi September 2, 2024 13:07
@github-actions github-actions bot added the feature: cli This is related to CLI label Sep 2, 2024
@tido64 tido64 merged commit 4aa8e55 into main Sep 3, 2024
10 checks passed
@tido64 tido64 deleted the tido/rnx-cli/output-command branch September 3, 2024 05:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature: cli This is related to CLI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants