Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tools-android): add primitives for build and run commands #3322

Merged
merged 1 commit into from
Aug 30, 2024

Conversation

tido64
Copy link
Member

@tido64 tido64 commented Aug 29, 2024

Description

Added Android support to the experimental commands for building and running apps. Again, this still needs more testing and will not be publicly available yet.

Test plan

  1. Patch in rnx-run:
    diff --git a/packages/cli/src/index.ts b/packages/cli/src/index.ts
    index 00b83a26..e0c540ee 100644
    --- a/packages/cli/src/index.ts
    +++ b/packages/cli/src/index.ts
    @@ -4,6 +4,7 @@ import { rnxBundleCommand } from "./bundle";
     import { rnxCleanCommand } from "./clean";
     import { rnxCopyAssetsCommand } from "./copy-assets";
     import { rnxRamBundleCommand } from "./ram-bundle";
    +import { rnxRunCommand } from "./run";
     import { rnxStartCommand } from "./start";
     import { rnxTestCommand } from "./test";
     import { rnxWriteThirdPartyNoticesCommand } from "./write-third-party-notices";
    @@ -12,6 +13,7 @@ export const reactNativeConfig = {
       commands: [
         rnxBundleCommand,
         rnxRamBundleCommand,
    +    rnxRunCommand,
         rnxStartCommand,
         rnxCopyAssetsCommand,
         rnxAlignDepsCommand,
  2. Build: yarn nx build @rnx-kit/test-app
  3. Verify:
    cd packages/test-app
    yarn react-native rnx-run --platform android

@tido64 tido64 requested a review from Saadnajmi August 29, 2024 19:49
@github-actions github-actions bot added the feature: cli This is related to CLI label Aug 29, 2024
@tido64 tido64 merged commit c2023a7 into main Aug 30, 2024
10 checks passed
@tido64 tido64 deleted the tido/cli/build-android branch August 30, 2024 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature: cli This is related to CLI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants