Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(cli): make implicit mocks explicit #3318

Merged
merged 2 commits into from
Aug 29, 2024
Merged

test(cli): make implicit mocks explicit #3318

merged 2 commits into from
Aug 29, 2024

Conversation

tido64
Copy link
Member

@tido64 tido64 commented Aug 29, 2024

Description

This makes it easier to migrate to Node test runner in the future. We cannot migrate today because we still need module mocking, which will become available in Node 22.

Test plan

CI should pass.

@github-actions github-actions bot added chore Improvements that don't directly affect features feature: cli This is related to CLI labels Aug 29, 2024
@tido64 tido64 marked this pull request as draft August 29, 2024 09:02
@tido64 tido64 force-pushed the tido/cli/tests branch 2 times, most recently from f012832 to 05c7b1b Compare August 29, 2024 09:26
This makes it easier to migrate to Node test runner in the future. We
cannot migrate today because we still need module mocking, which will
become available in Node 22.
@tido64 tido64 marked this pull request as ready for review August 29, 2024 10:18
@tido64 tido64 merged commit 66ba538 into main Aug 29, 2024
10 checks passed
@tido64 tido64 deleted the tido/cli/tests branch August 29, 2024 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Improvements that don't directly affect features feature: cli This is related to CLI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant