Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tools-react-native): fix crash on older versions of @react-native-community/cli #3296

Merged
merged 4 commits into from
Aug 20, 2024

Conversation

tido64
Copy link
Member

@tido64 tido64 commented Aug 15, 2024

Description

Fix crash when using @react-native-community/cli versions older than 7.x

Resolves #3295.

Test plan

Run:

yarn build @rnx-kit/test-app
cd packages/test-app
node -p 'require("../tools-react-native/platform.js").getAvailablePlatforms()'

This should output:

{ android: '', ios: '', windows: 'react-native-windows' }

@tido64 tido64 requested a review from Saadnajmi August 15, 2024 18:01
@github-actions github-actions bot added the feature: metro This is related to Metro label Aug 16, 2024
@tido64 tido64 force-pushed the tido/tools-react-native/fix-compat-older-versions branch from f5d257d to b8f0d7d Compare August 19, 2024 09:43
@github-actions github-actions bot removed the feature: metro This is related to Metro label Aug 19, 2024
@tido64 tido64 merged commit bfe2ab1 into main Aug 20, 2024
10 checks passed
@tido64 tido64 deleted the tido/tools-react-native/fix-compat-older-versions branch August 20, 2024 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants