Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RuntimeScheduler is only used by TurboModule Manager in >RN0.72 #2461

Merged
merged 4 commits into from
Jun 16, 2023
Merged

RuntimeScheduler is only used by TurboModule Manager in >RN0.72 #2461

merged 4 commits into from
Jun 16, 2023

Conversation

shwanton
Copy link
Contributor

Description

Test plan

  • Not sure how to test this inside RNXKit, however here is the AsyncStorage TM working on macOS with this fix:
CleanShot.2023-06-14.at.09.39.50.mp4

@shwanton shwanton changed the title RCTAppSetupDefaultJsExecutorFactory doesn't take a _runtimeScheduler Remove _runtimeScheduler param from RCTAppSetupDefaultJsExecutorFactory Jun 14, 2023
tido64
tido64 reviewed Jun 14, 2023
View reviewed changes
Copy link
Member

@tido64 tido64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing New Arch on 0.71! I thought we had tested this but apparently not 😅

packages/react-native-host/cocoa/RNXTurboModuleAdapter.mm Outdated Show resolved Hide resolved
@shwanton shwanton force-pushed the @shwanton/fix-turbomodule-adapter branch from dca4803 to 2c08b5c Compare June 15, 2023 21:23
tido64
tido64 approved these changes Jun 16, 2023
View reviewed changes
Copy link
Member

@tido64 tido64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking the time to fix this ❤️

@tido64
Copy link
Member

tido64 commented Jun 16, 2023 •
edited
Loading

image

Can you run yarn change at project root and add an appropriate change log entry?

Once this lands, I will publish a new version and bump it in react-native-test-app.

@shwanton shwanton changed the title Remove _runtimeScheduler param from RCTAppSetupDefaultJsExecutorFactory RuntimeScheduler is only used by TurboModule Manager in >RN0.72 Jun 16, 2023
@tido64 tido64 merged commit 79615c9 into microsoft:main Jun 16, 2023
@tido64 tido64 mentioned this pull request Jun 16, 2023
Closed
4 tasks
@shwanton shwanton mentioned this pull request Jun 16, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tido64 tido64 tido64 approved these changes

@kelset kelset Awaiting requested review from kelset

@JasonVMo JasonVMo Awaiting requested review from JasonVMo JasonVMo is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shwanton @tido64