Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Forwarded header for IPv4 with dual stack sockets #2509

Merged
merged 4 commits into from
May 20, 2024
Merged

Fix Forwarded header for IPv4 with dual stack sockets #2509

merged 4 commits into from
May 20, 2024

Conversation

rkargMsft
Copy link
Contributor

Similar to #2400 but for the Forwarded header

@rkargMsft
Copy link
Contributor Author

@microsoft-github-policy-service agree company="Microsoft"

@MihaZupan MihaZupan added this to the YARP 2.2 milestone May 18, 2024
MihaZupan
MihaZupan reviewed May 18, 2024
View reviewed changes
Copy link
Member

@MihaZupan MihaZupan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.
Could you move this logic into AppendNode such that it also applies to by='s LocalIpAddress?

@rkargMsft
Copy link
Contributor Author

Pulled out handling for both IP addresses

MihaZupan
MihaZupan approved these changes May 20, 2024
View reviewed changes
Copy link
Member

@MihaZupan MihaZupan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

src/ReverseProxy/Transforms/RequestHeaderForwardedTransform.cs Outdated Show resolved Hide resolved
@MihaZupan MihaZupan enabled auto-merge (squash) May 20, 2024 13:25
@MihaZupan MihaZupan merged commit ef089b0 into microsoft:main May 20, 2024
7 checks passed
@rkargMsft rkargMsft deleted the forwarded branch May 20, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MihaZupan MihaZupan MihaZupan approved these changes

@benjaminpetit benjaminpetit Awaiting requested review from benjaminpetit benjaminpetit is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
YARP 2.2
Development

Successfully merging this pull request may close these issues.
3 participants
@rkargMsft @MihaZupan @rkarg-blizz