Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Throw an exception in ConfigureHttpClient when custom IForwarderHttpClientFactory is added #1805

Merged
merged 3 commits into from
Aug 18, 2022
Merged

Throw an exception in ConfigureHttpClient when custom IForwarderHttpClientFactory is added #1805

merged 3 commits into from
Aug 18, 2022

Conversation

Kahbazi
Copy link
Collaborator

@Kahbazi Kahbazi commented Jul 15, 2022

Fixes #1799

@Tratcher Tratcher enabled auto-merge (squash) August 18, 2022 17:40
@Tratcher Tratcher added this to the YARP 2.0.0 milestone Aug 18, 2022
@Tratcher
Copy link
Member

Thanks @Kahbazi

@Tratcher Tratcher merged commit 2f4f9e7 into microsoft:main Aug 18, 2022
@Kahbazi Kahbazi deleted the ErrorConfigureHttpClient branch August 18, 2022 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tratcher Tratcher Tratcher approved these changes

@MihaZupan MihaZupan Awaiting requested review from MihaZupan MihaZupan is a code owner

Assignees

@Tratcher Tratcher

Labels
None yet
Projects
None yet
Milestone
YARP 2.0.0-RC1
Development

Successfully merging this pull request may close these issues.

Raise an Error in ConfigureHttpClient when custom IForwarderHttpClientFactory is added
3 participants
@Kahbazi @Tratcher @MihaZupan