Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom request/response modifications via code transforms #60

Closed
samsp-msft opened this issue Apr 15, 2020 · 4 comments · Fixed by #703
Closed

Custom request/response modifications via code transforms #60

samsp-msft opened this issue Apr 15, 2020 · 4 comments · Fixed by #703
Assignees
Labels
Type: Enhancement New feature or request

Comments

@samsp-msft
Copy link
Contributor

Ability to customize headers (beyond x-forward or affinity) from code extensibility for both request to back end, and response to the the client.

@samsp-msft samsp-msft added the Type: Enhancement New feature or request label Apr 15, 2020
@analogrelay analogrelay added this to the 1.0.0 milestone Apr 23, 2020
@Tratcher Tratcher self-assigned this May 11, 2020
@Tratcher
Copy link
Member

See feedback from #225 (comment) about config formats and how that may affect extensibility.

@Tratcher Tratcher removed their assignment Jul 7, 2020
@Tratcher Tratcher changed the title Custom header modifications via code Custom request/response modifications via code Sep 28, 2020
@AJAnderhub
Copy link

I would second the need for custom header modifications. Prepending to response headers would the use case for my scenario.

@Tratcher Tratcher changed the title Custom request/response modifications via code Custom request/response modifications via code transforms Nov 24, 2020
@robbieknuth
Copy link
Contributor

+1, I have a need to modify headers in an ad-hoc fashion. Concrete scenario is ripping an auth token from a cookie and setting that as the Authorization header. This would eliminate my need for CORS entirely and simplify my api server to be jwt only, resulting in all client-ish things on the client server.

@Tratcher
Copy link
Member

Tratcher commented Dec 29, 2020

Requirements summary:

  • Someone can write code to modify request and response parameters/headers.
  • That code can be associated with specific routes via config, including parameters.
  • Config validation can validate parameters for transforms.
  • Transforms compose so you don't have to write one uber transform.
  • Transformations need to allow async code.

Example scenarios:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants