fix: Move duplicate keys to else block #652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
looks good to me, although i'm curious if we could get rid of the else block entirely and just depend on the helm chart values.yaml |
|
Having a default in the template helps if the injected values somehow miss
the command and args. I have tested this by sending an empty map to the
operator key. This was most backwards compatible way for me to get the helm
chart working with our values. If someone out there is using it with the
default values for the reverse reason, I e. They have send empty command
and args to make the chart work, then removing them from the template will
break it for them.
Once the chart is stabilized and released we can get rid of the else block.
…On Tue, Aug 27, 2024, 01:58 Quang Nguyen ***@***.***> wrote:
looks good to me, although i'm curious if we could get rid of the else
block entirely and just depend on the helm chart values.yaml
—
Reply to this email directly, view it on GitHub
<#652 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AADX7BCDFYM75J56UGJ64G3ZTNJURAVCNFSM6AAAAABNDPFOU6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMJQGYYDCNBXHA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
nddq
approved these changes
Aug 26, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #651
Related Issue
If this pull request is related to any issue, please mention it here. Additionally, make sure that the issue is assigned to you before submitting this pull request.
Checklist
git commit -S -s ...). See this documentation on signing commits.Screenshots (if applicable) or Testing Completed
Please add any relevant screenshots or GIFs to showcase the changes made.
Additional Notes
Perhaps it would be a useful CI enhancement to run
helm template . | kubeconformor similar against these charts to reduce errors.Please refer to the CONTRIBUTING.md file for more information on how to contribute to this project.