fix: Test grafana dashboards in hubble deploy

[whatnick]

Description

Closes #501

Related Issue

The refactored hubble deployment included in grafana dashboard testing. Also renamed the dashboards folder to match the grafana application and the Makefile setup. This make phony is not run in CI and tests are run via make test so this folder issue does not show up.

Checklist

• I have read the contributing documentation.
• I signed and signed-off the commits (git commit -S -s ...). See this documentation on signing commits.
• I have correctly attributed the author(s) of the code.
• I have tested the changes locally.
• I have followed the project's style guidelines.
• I have updated the documentation, if necessary.
• I have added tests, if applicable.

Screenshots (if applicable) or Testing Completed

go test ./... -tags=dashboard -v
=== RUN   TestDashboardsAreSimplified
    simplify-grafana_test.go:21: verifying that dashboard is simplified: ../../../hubble/grafana/dashboards/clusters.json
    simplify-grafana_test.go:21: verifying that dashboard is simplified: ../../../hubble/grafana/dashboards/dns.json
    simplify-grafana_test.go:21: verifying that dashboard is simplified: ../../../hubble/grafana/dashboards/pod-flows-namespace.json
    simplify-grafana_test.go:21: verifying that dashboard is simplified: ../../../hubble/grafana/dashboards/pod-flows-workload.json
    simplify-grafana_test.go:21: verifying that dashboard is simplified: ../../../legacy/grafana/dashboards/clusters.json
    simplify-grafana_test.go:21: verifying that dashboard is simplified: ../../../legacy/grafana/dashboards/dns.json
    simplify-grafana_test.go:21: verifying that dashboard is simplified: ../../../legacy/grafana/dashboards/pod-level.json
--- PASS: TestDashboardsAreSimplified (0.01s)
PASS
ok      github.com/microsoft/retina/deploy/testutils/grafana/dashboards (cached)

make simplify-dashboards
cd deploy/testutils && go test ./... -tags=dashboard,simplifydashboard -v && cd /home/tisham/dev/retina
=== RUN   TestOverwriteDashboards
    simplify-grafana-overwrite_test.go:20: simplifying/overwriting dashboard: ../../../hubble/grafana/dashboards/clusters.json
    simplify-grafana-overwrite_test.go:20: simplifying/overwriting dashboard: ../../../hubble/grafana/dashboards/dns.json
    simplify-grafana-overwrite_test.go:20: simplifying/overwriting dashboard: ../../../hubble/grafana/dashboards/pod-flows-namespace.json
    simplify-grafana-overwrite_test.go:20: simplifying/overwriting dashboard: ../../../hubble/grafana/dashboards/pod-flows-workload.json
    simplify-grafana-overwrite_test.go:20: simplifying/overwriting dashboard: ../../../legacy/grafana/dashboards/clusters.json
    simplify-grafana-overwrite_test.go:20: simplifying/overwriting dashboard: ../../../legacy/grafana/dashboards/dns.json
    simplify-grafana-overwrite_test.go:20: simplifying/overwriting dashboard: ../../../legacy/grafana/dashboards/pod-level.json
--- PASS: TestOverwriteDashboards (0.01s)
PASS
ok      github.com/microsoft/retina/deploy/testutils/grafana/dashboards 0.013s

Additional Notes

This PR duplicates code if more dashboard folders are added it would perhaps be useful to improve the go test code to receive a list of folders instead.

---

Please refer to the CONTRIBUTING.md file for more information on how to contribute to this project.

[whatnick]

@microsoft-github-policy-service agree

[huntergregory]

Thanks for taking up this change @whatnick ! Mainly just had a thought about refactoring

[huntergregory]

This is great, thank you @whatnick ! If you haven't yet, could you just double check that simplifying dashboards works with the new make code? I would suggest locally reverting one of the deploy/hubble/ json files and seeing if it changes again after running make.

[whatnick]

This is great, thank you @whatnick ! If you haven't yet, could you just double check that simplifying dashboards works with the new make code? I would suggest locally reverting one of the deploy/hubble/ json files and seeing if it changes again after running make.

Yep manual changes get reverted by the test in overwrite mode.