chore: add windows ps1 hacks to native dockerfile #635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snguyen64
previously approved these changes
Aug 22, 2024
matmerr
force-pushed
the
matmerr/kubeconfigps1
branch
9 times, most recently
from
4f9731a
to
3a15442
Compare
matmerr
force-pushed
the
matmerr/kubeconfigps1
branch
3 times, most recently
from
aef7cf4
to
a9ae549
Compare
matmerr
force-pushed
the
matmerr/kubeconfigps1
branch
from
a9ae549
to
c7c8266
Compare
snguyen64
approved these changes
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
containerd 1.6 still requires secrets to be mounted in hacky way, which is all AKS versions <1.27
Azure/AKS#3975 (comment)
Related Issue
If this pull request is related to any issue, please mention it here. Additionally, make sure that the issue is assigned to you before submitting this pull request.
Checklist
git commit -S -s ...). See this documentation on signing commits.Screenshots (if applicable) or Testing Completed
Please add any relevant screenshots or GIFs to showcase the changes made.
Additional Notes
Add any additional notes or context about the pull request here.
Please refer to the CONTRIBUTING.md file for more information on how to contribute to this project.