Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add CPU profile to telemetry heartbeat #625

Merged
merged 4 commits into from
Aug 27, 2024

Conversation

matmerr
Copy link
Member

@matmerr matmerr commented Aug 20, 2024

Description

Adding CPU profile to heartbeat to determine user/sys cpu time over a given window

Related Issue

If this pull request is related to any issue, please mention it here. Additionally, make sure that the issue is assigned to you before submitting this pull request.

Checklist

  • I have read the contributing documentation.
  • I signed and signed-off the commits (git commit -S -s ...). See this documentation on signing commits.
  • I have correctly attributed the author(s) of the code.
  • I have tested the changes locally.
  • I have followed the project's style guidelines.
  • I have updated the documentation, if necessary.
  • I have added tests, if applicable.

Screenshots (if applicable) or Testing Completed

Please add any relevant screenshots or GIFs to showcase the changes made.

Additional Notes

Add any additional notes or context about the pull request here.


Please refer to the CONTRIBUTING.md file for more information on how to contribute to this project.

@matmerr matmerr requested a review from a team as a code owner August 20, 2024 22:45
@nddq nddq added type/enhancement New feature or request area/metrics labels Aug 21, 2024
Copy link
Member

@timraymond timraymond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nit only, but I would take the linter's recommendations to use strconv over fmt.Sprintf.

pkg/telemetry/perf.go Outdated Show resolved Hide resolved
pkg/telemetry/telemetry.go Outdated Show resolved Hide resolved
@matmerr matmerr force-pushed the matmerr/cpuprofile branch 7 times, most recently from b092c6c to 6192e5e Compare August 23, 2024 17:16
@matmerr matmerr enabled auto-merge August 26, 2024 18:19
@matmerr matmerr dismissed timraymond’s stale review August 27, 2024 17:03

Updated to use strconv

@matmerr matmerr added this pull request to the merge queue Aug 27, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 27, 2024
@matmerr matmerr added this pull request to the merge queue Aug 27, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 27, 2024
@matmerr matmerr added this pull request to the merge queue Aug 27, 2024
Merged via the queue into microsoft:main with commit 9751894 Aug 27, 2024
22 checks passed
@matmerr matmerr deleted the matmerr/cpuprofile branch August 27, 2024 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/metrics type/enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants