feat(conntrack): conntrack integration with packetparser #624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Quang Nguyen <[email protected]>
nddq
added
type/enhancement
11 tasks
nddq
requested review from
vakalapa and
anubhabMajumdar
and removed request for
ibezrukavyi and
karina-ranadive
nddq
commented
Sep 4, 2024
MikeZappa87
reviewed
Sep 5, 2024
vakalapa
approved these changes
Sep 6, 2024
rectified95
reviewed
Sep 6, 2024
rectified95
approved these changes
Sep 6, 2024
matmerr
reviewed
Oct 15, 2024
| @@ -31,22 +31,15 @@ const ( | |||
| // 2 is from host to network and 3 is from network to host. | |||
| // ts is the timestamp in nanoseconds. | |||
| func ToFlow( | |||
| l *log.ZapLogger, | |||
There was a problem hiding this comment.
is there any extra reasoning to passing logger here besides warn? this was pretty concise, requires refactoring usage downstream just for a warn
There was a problem hiding this comment.
There is no reason to pass the logger here. From some of the pprof we collected, this actually incurred quite a bit of memory usage.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Part 2 of #610
Related Issue
If this pull request is related to any issue, please mention it here. Additionally, make sure that the issue is assigned to you before submitting this pull request.
Checklist
git commit -S -s ...). See this documentation on signing commits.Screenshots (if applicable) or Testing Completed
Output from debug CLI tool:
Hubble flow logs:
Additional Notes
Add any additional notes or context about the pull request here.
Please refer to the CONTRIBUTING.md file for more information on how to contribute to this project.