-
Notifications
You must be signed in to change notification settings - Fork 213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: apiserver watcher refresh shouldn't crash plugin manager #576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimassa
changed the title
fix: Watcher Refresh shouldn't crash plugin manager
fix: watcher refresh shouldn't crash plugin manager
Jul 31, 2024
rbtr
reviewed
Jul 31, 2024
jimassa
changed the title
fix: watcher refresh shouldn't crash plugin manager
fix: apiserver watcher refresh shouldn't crash plugin manager
Aug 12, 2024
…move getHostname into Init
…etina into jmassa/api_watcher_fix
…etina into jmassa/api_watcher_fix
…etina into jmassa/api_watcher_fix
…etina into jmassa/api_watcher_fix
anubhabMajumdar
approved these changes
Aug 20, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Aug 20, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR modifies the APIServer watcher to improve error handling and optimize performance:
Related Issue
#565
If this pull request is related to any issue, please mention it here. Additionally, make sure that the issue is assigned to you before submitting this pull request.
Checklist
git commit -S -s ...
). See this documentation on signing commits.Screenshots (if applicable) or Testing Completed
Please add any relevant screenshots or GIFs to showcase the changes made.
Additional Notes
Add any additional notes or context about the pull request here.
Please refer to the CONTRIBUTING.md file for more information on how to contribute to this project.