-
Notifications
You must be signed in to change notification settings - Fork 213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cil): add cilium plugin to read events off unix socket #570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snguyen64
force-pushed
the
feat/cil-plugin
branch
19 times, most recently
from
August 6, 2024 21:08
f865900
to
96beb2a
Compare
snguyen64
requested review from
huntergregory,
spencermckee,
anubhabMajumdar and
vakalapa
August 6, 2024 21:15
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Main question I have: should we retry if the socket connection is closed?
snguyen64
force-pushed
the
feat/cil-plugin
branch
3 times, most recently
from
August 7, 2024 17:06
6a12c01
to
9dee9db
Compare
snguyen64
force-pushed
the
feat/cil-plugin
branch
2 times, most recently
from
August 13, 2024 23:10
eea63d6
to
cc08f1d
Compare
snguyen64
force-pushed
the
feat/cil-plugin
branch
from
August 16, 2024 15:33
8192972
to
9285552
Compare
anubhabMajumdar
approved these changes
Aug 16, 2024
vakalapa
approved these changes
Aug 20, 2024
snguyen64
force-pushed
the
feat/cil-plugin
branch
from
August 20, 2024 18:41
ec6ddf2
to
410276d
Compare
snguyen64
force-pushed
the
feat/cil-plugin
branch
from
August 20, 2024 19:11
410276d
to
01687e5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added cilium plugin for retina-agent. This plugin will read events from cilium monitor socket, parse + decode to flow structs and send the events to our hubble instance
Related Issue
If this pull request is related to any issue, please mention it here. Additionally, make sure that the issue is assigned to you before submitting this pull request.
Checklist
git commit -S -s ...
). See this documentation on signing commits.Screenshots (if applicable) or Testing Completed
Tested on cilium cluster + retina-agent w/ cilium plugin. Run wget on bing.com and check metrics
Plugins enabled [cilium]
plugins enabled [cilium,dns]
Testing hubble-relay observe flows
on observe flow, pipe is broken on tcp4 when portforwarding, but flows show as expected otherwise
hubble-ui - shows flows/s but does not show service map
Testing on retina + hubble on non cilium (regression test)
2 node cluster
Plugins enabled
If we try to enable ciliumeventobserver on non cilium, it will crash
Hubble relay
hubble ui
Additional Notes
Add any additional notes or context about the pull request here.
Please refer to the CONTRIBUTING.md file for more information on how to contribute to this project.