fix: capture commands should respect --namespace #568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rbtr
added
lang/go
timraymond
reviewed
Aug 2, 2024
mainred
reviewed
Aug 5, 2024
rbtr
force-pushed
the
fix/capture-namespace
branch
from
4137260
to
fdb4a33
Compare
timraymond
reviewed
Aug 7, 2024
|
This PR will be closed in 7 days due to inactivity. |
github-actions
bot
added
the
meta/waiting-for-author
|
This PR will be closed in 7 days due to inactivity. |
github-actions
bot
added
the
meta/waiting-for-author
rbtr
force-pushed
the
fix/capture-namespace
branch
from
fdb4a33
to
59d48cd
Compare
kamilprz
reviewed
Nov 22, 2024
rbtr
force-pushed
the
fix/capture-namespace
branch
2 times, most recently
from
44e3f16
to
5eb2043
Compare
kamilprz
approved these changes
Nov 25, 2024
rbtr
force-pushed
the
fix/capture-namespace
branch
2 times, most recently
from
ca35ad0
to
467d923
Compare
|
not sure why my key is unverified, I'm signing in a codespace 😠 |
rbtr
force-pushed
the
fix/capture-namespace
branch
3 times, most recently
from
1180dd2
to
42925e6
Compare
Signed-off-by: Evan Baker <[email protected]> Signed-off-by: GitHub <[email protected]>
rbtr
force-pushed
the
fix/capture-namespace
branch
from
42925e6
to
cb47151
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix
capturesubcommands to respect the cli-runtime--namespaceCLI flag.Related Issue
Closes #477
Checklist
git commit -S -s ...). See this documentation on signing commits.Please refer to the CONTRIBUTING.md file for more information on how to contribute to this project.