fix: correctly assign the subtype value in flow for drop reason #413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anubhabMajumdar
force-pushed
the
topic/anmajumdar/fix-dropreason-subtype
branch
from
5f181b4
to
6c3892f
Compare
rbtr
approved these changes
May 30, 2024
|
@anubhabMajumdar rebase doesn't sign your previous commits unfortunately 🥲 |
vakalapa
approved these changes
May 30, 2024
Signed-off-by: Anubhab Majumdar <[email protected]>
anubhabMajumdar
force-pushed
the
topic/anmajumdar/fix-dropreason-subtype
branch
from
6c3892f
to
7249d8c
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
matmerr
pushed a commit
to matmerr/retina
that referenced
this pull request
Jul 3, 2024
…osoft#413) The `subType` field for flows of type Drop needs to be the DropReason, not the point of observation. - [x] I have read the [contributing documentation](https://retina.sh/docs/contributing). - [x] I signed and signed-off the commits (`git commit -S -s ...`). See [this documentation](https://docs.github.com/en/authentication/managing-commit-signature-verification/about-commit-signature-verification) on signing commits. - [x] I have correctly attributed the author(s) of the code. - [x] I have tested the changes locally. - [x] I have followed the project's style guidelines. - [x] I have updated the documentation, if necessary. - [x] I have added tests, if applicable. Checked the flows through debug logging to make sure the SubType is set correctly. --- Please refer to the [CONTRIBUTING.md](../CONTRIBUTING.md) file for more information on how to contribute to this project. Signed-off-by: Anubhab Majumdar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
subTypefield for flows of type Drop needs to be the DropReason, not the point of observation.Checklist
git commit -S -s ...). See this documentation on signing commits.Screenshots (if applicable) or Testing Completed
Checked the flows through debug logging to make sure the SubType is set correctly.
Please refer to the CONTRIBUTING.md file for more information on how to contribute to this project.