fix: Fix missing return code for dns response #329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Anubhab Majumdar <[email protected]>
anubhabMajumdar
changed the title
Signed-off-by: Anubhab Majumdar <[email protected]>
huntergregory
approved these changes
May 1, 2024
nddq
pushed a commit
that referenced
this pull request
May 6, 2024
# Description IG recently changed the return code of the DNS gadget and moved to gopacket - https://github.com/inspektor-gadget/inspektor-gadget/blame/6a5937bba8f13fee889a24340f309d57e8ecabb6/pkg/gadgets/trace/dns/tracer/tracer.go#L168 . Fix the map in utils. ## Related Issue Fix: #330 ## Checklist - [x] I have read the [contributing documentation](https://retina.sh/docs/contributing). - [x] I signed and signed-off the commits (`git commit -S -s ...`). See [this documentation](https://docs.github.com/en/authentication/managing-commit-signature-verification/about-commit-signature-verification) on signing commits. - [ ] I have correctly attributed the author(s) of the code. - [x] I have tested the changes locally. - [ ] I have followed the project's style guidelines. - [ ] I have updated the documentation, if necessary. - [x] I have added tests, if applicable. ## Screenshots (if applicable) or Testing Completed Please add any relevant screenshots or GIFs to showcase the changes made. ## Additional Notes Add any additional notes or context about the pull request here. --- Please refer to the [CONTRIBUTING.md](../CONTRIBUTING.md) file for more information on how to contribute to this project. --------- Signed-off-by: Anubhab Majumdar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
IG recently changed the return code of the DNS gadget and moved to gopacket - https://github.com/inspektor-gadget/inspektor-gadget/blame/6a5937bba8f13fee889a24340f309d57e8ecabb6/pkg/gadgets/trace/dns/tracer/tracer.go#L168 . Fix the map in utils.
Related Issue
Fix: #330
Checklist
git commit -S -s ...). See this documentation on signing commits.Screenshots (if applicable) or Testing Completed
Please add any relevant screenshots or GIFs to showcase the changes made.
Additional Notes
Add any additional notes or context about the pull request here.
Please refer to the CONTRIBUTING.md file for more information on how to contribute to this project.