-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: the ebpf program in the tcpretrans plugin failed to load #322
Conversation
Signed-off-by: wenhuwang <[email protected]>
Signed-off-by: wenhuwang <[email protected]>
@wenhuwang this doesn't seem to fully resolve the problem. Instead of a nil pointer, now there is an error instantiating the socketEnricher:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
needs to be tested
@rbtr Sorry for the late reply, I'm on vacation recently. I have tested it locally before. I will verify this problem in a few days. |
I have not reproduced this problem and retina-agent status is normal in local environment .
platform: Do you have any specific steps to reproduce the problem? @rbtr |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the change. Can you add details as to how you verified this change?
|
Signed-off-by: wenhuwang <[email protected]>
Head branch was pushed to by a user without write access
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
enabling tcpretrans plugin lgtm now, thanks @wenhuwang
…oft#322) # Description Fix the issues of abnormal status of retina-agent caused by opening tcpretrans plugin. The retina-agent nil pointer is because the [Tracer.socketEnricherMap](https://github.com/inspektor-gadget/inspektor-gadget/blob/main/pkg/gadgets/trace/tcpretrans/tracer/tracer.go#L41) field of the tcpretrans plugin is nil. ## Related Issue microsoft#311 ## Checklist - [x] I have read the [contributing documentation](https://retina.sh/docs/contributing). - [x] I signed and signed-off the commits (`git commit -S -s ...`). See [this documentation](https://docs.github.com/en/authentication/managing-commit-signature-verification/about-commit-signature-verification) on signing commits. - [x] I have correctly attributed the author(s) of the code. - [x] I have tested the changes locally. - [ ] I have followed the project's style guidelines. - [ ] I have updated the documentation, if necessary. - [ ] I have added tests, if applicable. --- Please refer to the [CONTRIBUTING.md](../CONTRIBUTING.md) file for more information on how to contribute to this project. --------- Signed-off-by: wenhuwang <[email protected]> Co-authored-by: Evan Baker <[email protected]>
Description
Fix the issues of abnormal status of retina-agent caused by opening tcpretrans plugin. The retina-agent nil pointer is because the Tracer.socketEnricherMap field of the tcpretrans plugin is nil.
Related Issue
#311
Checklist
git commit -S -s ...
). See this documentation on signing commits.Please refer to the CONTRIBUTING.md file for more information on how to contribute to this project.