feat: infiniband plugin #304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spencermckee
force-pushed
the
spencermckee/infiniband-plugin
branch
5 times, most recently
from
278f3ae
to
902d328
Compare
spencermckee
force-pushed
the
spencermckee/infiniband-plugin
branch
from
902d328
to
2bf81a5
Compare
estebancams
reviewed
May 13, 2024
image-metadata-retina-agent-v0.0.5-24-g77b2e86-linux-amd64.json
Outdated
Show resolved
Hide resolved
matmerr
previously requested changes
May 14, 2024
pkg/plugin/infiniband/testdata/infiniband/mlx5_an0/ports/1/counters/VL15_dropped
Outdated
Show resolved
Hide resolved
estebancams
previously approved these changes
May 21, 2024
spencermckee
force-pushed
the
spencermckee/infiniband-plugin
branch
3 times, most recently
from
7432c7d
to
58a6204
Compare
spencermckee
force-pushed
the
spencermckee/infiniband-plugin
branch
2 times, most recently
from
63d7186
to
d289b57
Compare
spencermckee
force-pushed
the
spencermckee/infiniband-plugin
branch
from
d289b57
to
aba99ed
Compare
spencermckee
force-pushed
the
spencermckee/infiniband-plugin
branch
from
aba99ed
to
d44e5d5
Compare
matmerr
approved these changes
Jun 3, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
spencermckee
force-pushed
the
spencermckee/infiniband-plugin
branch
from
d44e5d5
to
d7819a7
Compare
spencermckee
force-pushed
the
spencermckee/infiniband-plugin
branch
from
d7819a7
to
29ce809
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
matmerr
pushed a commit
to matmerr/retina
that referenced
this pull request
Jul 3, 2024
# Description Adds a plugin to collect metrics from the Nvidia Infiniband driver port counters at /sys/class/infiniband/<device>/ports/<port>/counters and debug status parameters at /sys/class/net/<iface>/debug. The data is available as two new metrics, InfinibandCounterStats (labels: counter name, device, and port) and InfinibandStatusParams (labels: status param name and interface). ## Checklist - [x] I have read the [contributing documentation](https://retina.sh/docs/contributing). - [x] I signed and signed-off the commits (`git commit -S -s ...`). See [this documentation](https://docs.github.com/en/authentication/managing-commit-signature-verification/about-commit-signature-verification) on signing commits. - [x] I have correctly attributed the author(s) of the code. - [x] I have tested the changes locally. - [x] I have followed the project's style guidelines. - [x] I have updated the documentation, if necessary. - [x] I have added tests, if applicable. --- Please refer to the [CONTRIBUTING.md](../CONTRIBUTING.md) file for more information on how to contribute to this project.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a plugin to collect metrics from the Nvidia Infiniband driver port counters at /sys/class/infiniband//ports//counters and debug status parameters at /sys/class/net//debug. The data is available as two new metrics, InfinibandCounterStats (labels: counter name, device, and port) and InfinibandStatusParams (labels: status param name and interface).
Checklist
git commit -S -s ...). See this documentation on signing commits.Please refer to the CONTRIBUTING.md file for more information on how to contribute to this project.