Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(builds): Refactor and cleanup make rules #28

Merged
merged 4 commits into from
Mar 13, 2024
Merged

fix(builds): Refactor and cleanup make rules #28

merged 4 commits into from
Mar 13, 2024

Conversation

anubhabMajumdar
Copy link
Contributor

@anubhabMajumdar anubhabMajumdar commented Mar 13, 2024 •
edited
Loading

Get the make rules and pipelines to work.

Testing Done

$ PLATFORM=linux/amd64 make retina-image
...
$ PLATFORM=linux/arm64 make retina-image
...
$ make retina-ut
...
$ make all-gen
...
$ make retina-image-win
...

@anubhabMajumdar
Fixed build + dockerfiles
c06e566 
Signed-off-by: Anubhab Majumdar <[email protected]>
@anubhabMajumdar anubhabMajumdar requested a review from a team as a code owner March 13, 2024 04:39
jimassa
jimassa reviewed Mar 13, 2024
View reviewed changes
Makefile Show resolved Hide resolved
jimassa
jimassa reviewed Mar 13, 2024
View reviewed changes
Makefile Outdated Show resolved Hide resolved
@rbtr rbtr merged commit f477347 into main Mar 13, 2024
16 of 20 checks passed
@rbtr rbtr deleted the topic/anmajumdar/builds branch March 13, 2024 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jimassa jimassa jimassa left review comments

@vakalapa vakalapa vakalapa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@anubhabMajumdar @jimassa @vakalapa @rbtr