feat(cli): add logs to check portguid #228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mena77
approved these changes
Apr 4, 2024
giovanadanieles
changed the title
rbtr
reviewed
Apr 4, 2024
rbtr
added
type/enhancement
rbtr
previously approved these changes
Apr 5, 2024
matmerr
reviewed
Apr 5, 2024
|
@giovanadanieles, recently @rbtr added some docs to show how to manually test on kubernetes cluster using an image that can be created from your own fork: https://retina.sh/docs/contributing/developing/#publishing-images-and-charts if you have any feedback/run into problems, feel free to open a github issue as well |
…/hack/tools (microsoft#222) Bumps [github.com/goreleaser/goreleaser](https://github.com/goreleaser/goreleaser) from 1.25.0 to 1.25.1. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/goreleaser/goreleaser/releases">github.com/goreleaser/goreleaser's releases</a>.</em></p> <blockquote> <h2>v1.25.1</h2> <h2>Changelog</h2> <h3>Bug fixes</h3> <ul> <li>053eccdba08b889e439d684a9c17c9b9fab3d3c2: fix(release): only change release draft status on new releases (<a href="https://redirect.github.com/goreleaser/goreleaser/issues/4744">#4744</a>) (<a href="https://github.com/caarlos0"><code>@caarlos0</code></a>)</li> <li>22b7daadb460cdb00b53da2d6661698227c690d3: fix(release): publish tag with skip_upload (<a href="https://redirect.github.com/goreleaser/goreleaser/issues/4745">#4745</a>) (<a href="https://github.com/caarlos0"><code>@caarlos0</code></a>)</li> <li>0ff94f13e4e5f71bd2972a8935e7223b30481ca6: fix: properly skip docker builds of skipped builds (<a href="https://redirect.github.com/goreleaser/goreleaser/issues/4747">#4747</a>) (<a href="https://github.com/caarlos0"><code>@caarlos0</code></a>)</li> </ul> <h3>Documentation updates</h3> <ul> <li>d972be970447466bee19291c5e1188807b6a973b: docs: announce v1.25 (<a href="https://github.com/caarlos0"><code>@caarlos0</code></a>)</li> <li>6a7a9ba3995728a4bdf7b5fff770d8caeb3d2cc8: docs: fix deprecation typos (<a href="https://redirect.github.com/goreleaser/goreleaser/issues/4750">#4750</a>) (<a href="https://github.com/j178"><code>@j178</code></a>)</li> </ul> <h3>Build process updates</h3> <ul> <li>85cb59c1a0236008a96368b677e38b8fd9f8573b: build: simplify (<a href="https://redirect.github.com/goreleaser/goreleaser/issues/4748">#4748</a>) (<a href="https://github.com/caarlos0"><code>@caarlos0</code></a>)</li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/goreleaser/goreleaser/compare/v1.25.0...v1.25.1">https://github.com/goreleaser/goreleaser/compare/v1.25.0...v1.25.1</a></p> <h2>Helping out</h2> <p>This release is only possible thanks to <strong>all</strong> the support of some <strong>awesome people</strong>!</p> <p>Want to be one of them? You can <a href="https://goreleaser.com/sponsors/">sponsor</a>, get a <a href="https://goreleaser.com/pro">Pro License</a> or <a href="https://goreleaser.com/contributing">contribute with code</a>.</p> <h2>Where to go next?</h2> <ul> <li>Find examples and commented usage of all options in our <a href="https://goreleaser.com/intro/">website</a>.</li> <li>Reach out on <a href="https://discord.gg/RGEBtg8vQ6">Discord</a> and <a href="https://twitter.com/goreleaser">Twitter</a>!</li> </ul> <p><!-- raw HTML omitted --><!-- raw HTML omitted --><!-- raw HTML omitted --></p> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/goreleaser/goreleaser/commit/6a7a9ba3995728a4bdf7b5fff770d8caeb3d2cc8"><code>6a7a9ba</code></a> docs: fix deprecation typos (<a href="https://redirect.github.com/goreleaser/goreleaser/issues/4750">#4750</a>)</li> <li><a href="https://github.com/goreleaser/goreleaser/commit/85cb59c1a0236008a96368b677e38b8fd9f8573b"><code>85cb59c</code></a> build: simplify (<a href="https://redirect.github.com/goreleaser/goreleaser/issues/4748">#4748</a>)</li> <li><a href="https://github.com/goreleaser/goreleaser/commit/053eccdba08b889e439d684a9c17c9b9fab3d3c2"><code>053eccd</code></a> fix(release): only change release draft status on new releases (<a href="https://redirect.github.com/goreleaser/goreleaser/issues/4744">#4744</a>)</li> <li><a href="https://github.com/goreleaser/goreleaser/commit/22b7daadb460cdb00b53da2d6661698227c690d3"><code>22b7daa</code></a> fix(release): publish tag with skip_upload (<a href="https://redirect.github.com/goreleaser/goreleaser/issues/4745">#4745</a>)</li> <li><a href="https://github.com/goreleaser/goreleaser/commit/0ff94f13e4e5f71bd2972a8935e7223b30481ca6"><code>0ff94f1</code></a> fix: properly skip docker builds of skipped builds (<a href="https://redirect.github.com/goreleaser/goreleaser/issues/4747">#4747</a>)</li> <li><a href="https://github.com/goreleaser/goreleaser/commit/d972be970447466bee19291c5e1188807b6a973b"><code>d972be9</code></a> docs: announce v1.25</li> <li><a href="https://github.com/goreleaser/goreleaser/commit/b9dc6dfe1ab957fc399e330fdd1369336f349b95"><code>b9dc6df</code></a> chore: auto-update generated files</li> <li>See full diff in <a href="https://github.com/goreleaser/goreleaser/compare/v1.25.0...v1.25.1">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: gdasilva <[email protected]>
Signed-off-by: gdasilva <[email protected]>
Signed-off-by: gdasilva <[email protected]>
Signed-off-by: gdasilva <[email protected]>
giovanadanieles
force-pushed
the
users/gdasilva/vfpChangesLogs
branch
from
c98d1c7
to
99ac4d2
Compare
Signed-off-by: gdasilva <[email protected]>
…ovanadanieles/retina into users/gdasilva/vfpChangesLogs
rbtr
approved these changes
Apr 15, 2024
nddq
pushed a commit
that referenced
this pull request
May 6, 2024
# Description This PR introduces some logs in order to check portguid. It also presents some slight modifications to improve readability and attend to Golang best practices ([ref](https://github.com/uber-go/guide/blob/master/style.md#initializing-structs)). ## Related Issue No related issues. ## Checklist - [X] I have read the [contributing documentation](https://retina.sh/docs/contributing). - [X] I signed and signed-off the commits (`git commit -S -s ...`) - [X] I have correctly attributed the author(s) of the code. - [X] I have tested the changes locally. - [X] I have followed the project's style guidelines. - [X] I have updated the documentation, if necessary. - [X] I have added tests, if applicable. ## Screenshots (if applicable) or Testing Completed No additional tests needed, just added two log lines. Existing tests are passing:  --- Please refer to the [CONTRIBUTING.md](../CONTRIBUTING.md) file for more information on how to contribute to this project. --------- Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: gdasilva <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces some logs in order to check portguid. It also presents some slight modifications to improve readability and attend to Golang best practices (ref).
Related Issue
No related issues.
Checklist
git commit -S -s ...)Screenshots (if applicable) or Testing Completed
No additional tests needed, just added two log lines. Existing tests are passing:
Please refer to the CONTRIBUTING.md file for more information on how to contribute to this project.