Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update string when no datapoint selected for local importance #1331

Merged
merged 1 commit into from
Apr 9, 2022
Merged

Update string when no datapoint selected for local importance #1331

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...shboard-e2e/src/describer/interpret/individualFeatureImportance/describeDataPointChart.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ export function describeDataPointChart(dataShape: IInterpretData): void {
it("should show message on sub chart", () => {
const message =
!dataShape.noLocalImportance && !dataShape.noFeatureImportance
? "Select a point to see its local importance"
? "Select a datapoint in the table above to view its local feature importances"
: "Provide local feature importances to see how each feature impacts individual predictions.";
cy.get("#subPlotContainer").should("contain.text", message);
});
Expand Down
2 changes: 1 addition & 1 deletion ...modelAssessment/featureImportances/individualFeatureImportance/describeTabularDataView.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ export function describeTabularDataView(dataShape: IModelAssessmentData): void {
const message =
!dataShape.featureImportanceData?.noLocalImportance &&
!dataShape.featureImportanceData?.noFeatureImportance
? "Select a point to see its local importance"
? "Select a datapoint in the table above to view its local feature importances"
: "Provide local feature importances to see how each feature impacts individual predictions.";
cy.get("#subPlotContainer").should("contain.text", message);
});
Expand Down
2 changes: 1 addition & 1 deletion libs/localization/src/lib/en.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1151,7 +1151,7 @@
"dataPointInfo": "Data point info",
"deltaLabel": "Delta",
"disclaimer": "Disclaimer: These are explanations based on many approximations and are not the \"cause\" of predictions. Without strict mathematical robustness of causal inference, we do not advise users to make real-life decisions based on this tool.",
"featureImportanceGetStartedText": "Select a point to see its local importance",
"featureImportanceGetStartedText": "Select a datapoint in the table above to view its local feature importances",
"featureImportanceLackingParameters": "Provide local feature importances to see how each feature impacts individual predictions.",
"featureImportancePlot": "Feature importance plot",
"featureValues": "Feature values",
Expand Down