Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add excludes cohort filter test in erroranalysis #1171

Merged
merged 5 commits into from
Jan 26, 2022
Merged

Conversation

gaugup
Copy link
Contributor

@gaugup gaugup commented Jan 25, 2022

Description

It seems that this test was missing. Also moved the cohort filter methods under a class and changed the references.

Areas changed

npm packages changed:

  • responsibleai/causality
  • responsibleai/core-ui
  • responsibleai/counterfactuals
  • responsibleai/dataset-explorer
  • responsibleai/fairness
  • responsibleai/interpret
  • responsibleai/localization
  • responsibleai/mlchartlib
  • responsibleai/model-assessment

Python packages changed:

  • raiwidgets
  • responsibleai
  • erroranalysis
  • rai_core_flask

Tests

  • No new tests required.
  • New tests for the added feature are part of this PR.
  • I validated the changes manually.

Screenshots (if appropriate):

Documentation:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

Signed-off-by: Gaurav Gupta <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Jan 25, 2022

Codecov Report

Merging #1171 (6560ba4) into main (60e4c66) will increase coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1171      +/-   ##
==========================================
+ Coverage   67.57%   67.62%   +0.05%     
==========================================
  Files          90       90              
  Lines        4274     4275       +1     
==========================================
+ Hits         2888     2891       +3     
+ Misses       1386     1384       -2     
Flag Coverage Δ
unittests 67.62% <100.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ranalysis/erroranalysis/_internal/cohort_filter.py 89.51% <100.00%> (+1.05%) ⬆️
erroranalysis/erroranalysis/_internal/constants.py 100.00% <100.00%> (ø)
...is/erroranalysis/_internal/surrogate_error_tree.py 92.51% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 60e4c66...6560ba4. Read the comment docs.

Copy link
Contributor

@romanlutz romanlutz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the new test case!

@gaugup gaugup enabled auto-merge (squash) January 26, 2022 03:58
1 similar comment
@gaugup gaugup merged commit efcfe07 into main Jan 26, 2022
@gaugup gaugup deleted the gaugup/AddExcludesTestEA branch January 26, 2022 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants