Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix RNX MenuFlyout so that it can update when number of child MenuFly… #290

Closed
wants to merge 1 commit into from
Closed

fix RNX MenuFlyout so that it can update when number of child MenuFly… #290

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions package/windows/ReactNativeXaml/XamlViewManager.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -346,6 +346,12 @@ void XamlViewManager::RemoveChildAt(xaml::FrameworkElement parent, int64_t index
return panel.Children().RemoveAt(static_cast<uint32_t>(index));
} else if (auto itemsControl = e.try_as<ItemsControl>()) {
return itemsControl.Items().RemoveAt(static_cast<uint32_t>(index));
} else if (auto wrapper = e.try_as<Wrapper>()) {
if (auto parentContent = wrapper.WrappedObject()) {
if (auto menuFlyout = parentContent.try_as<MenuFlyout>()) {
return menuFlyout.Items().RemoveAt(static_cast<uint32_t>(index));
}
}
} else if (index == 0) {
if (auto contentCtrl = e.try_as<ContentControl>()) {
return contentCtrl.Content(nullptr);
Expand Down
Loading