Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove example PFX files from repo #275

Merged
merged 1 commit into from
Feb 15, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 22 additions & 1 deletion .github/workflows/template-buildexample.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,10 @@ on:
required: false
default: 'example'
type: string
useBuildCertificate:
required: false
default: false
type: boolean

jobs:
build-example:
Expand All @@ -25,8 +29,25 @@ jobs:
- name: build TS
run: yarn build

- name: Decode the pfx
if: ${{ inputs.useBuildCertificate }}
run: |
$PfxBytes = [System.Convert]::FromBase64String("${{ secrets.EXAMPES_BASE64_ENCODED_PFX }}")
$PfxPath = [System.IO.Path]::GetFullPath("${{github.workspace}}\GitHubActionsWorkflow.pfx")
Write-Host $PfxPath
[System.IO.File]::WriteAllBytes("$PfxPath", $PfxBytes)
working-directory: ${{ inputs.exampleName }}

- name: yarn windows
run: yarn windows --no-launch --no-deploy --no-packager --logging
run: yarn windows --no-launch --no-deploy --no-packager --logging ${{ inputs.useBuildCertificate && '--msbuildprops PackageCertificateKeyFile=${{github.workspace}}\GitHubActionsWorkflow.pfx' || '' }}
working-directory: ${{ inputs.exampleName }}

- name: Remove the pfx
if: ${{ inputs.useBuildCertificate }}
run: |
$certificatePath = [System.IO.Path]::GetFullPath("${{github.workspace}}\GitHubActionsWorkflow.pfx")
Write-Host $certificatePath
Remove-Item -path $certificatePath
working-directory: ${{ inputs.exampleName }}

- name: test app
Expand Down
3 changes: 0 additions & 3 deletions example/windows/example/example.vcxproj
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,6 @@
<AppContainerApplication>true</AppContainerApplication>
<ApplicationType>Windows Store</ApplicationType>
<ApplicationTypeRevision>10.0</ApplicationTypeRevision>
<PackageCertificateKeyFile>example_TemporaryKey.pfx</PackageCertificateKeyFile>
<PackageCertificateThumbprint>75F170D34994859553AF5C50C18A9AECDD312B27</PackageCertificateThumbprint>
</PropertyGroup>
<PropertyGroup Label="ReactNativeWindowsProps">
<ReactNativeWindowsDir Condition="'$(ReactNativeWindowsDir)' == ''">$([MSBuild]::GetDirectoryNameOfFileAbove($(SolutionDir), 'node_modules\react-native-windows\package.json'))\node_modules\react-native-windows\</ReactNativeWindowsDir>
Expand Down Expand Up @@ -152,7 +150,6 @@
<ItemGroup>
<None Include="..\..\App.tsx" />
<None Include="..\..\index.js" />
<None Include="example_TemporaryKey.pfx" />
<None Include="packages.config" />
<None Include="PropertySheet.props" />
<Text Include="readme.txt">
Expand Down
Binary file removed example/windows/example/example_TemporaryKey.pfx
Binary file not shown.
3 changes: 0 additions & 3 deletions examplenuget/windows/examplenuget/examplenuget.vcxproj
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,6 @@
<ApplicationType>Windows Store</ApplicationType>
<ApplicationTypeRevision>10.0</ApplicationTypeRevision>
<ReactNativeWindowsAllowNugetNpmMismatch>true</ReactNativeWindowsAllowNugetNpmMismatch>
<PackageCertificateKeyFile>examplenuget_TemporaryKey.pfx</PackageCertificateKeyFile>
<PackageCertificateThumbprint>CA08428B1920E77BE093E559694FE56031D6E5E9</PackageCertificateThumbprint>
</PropertyGroup>
<PropertyGroup Label="ReactNativeWindowsProps">
<ReactNativeWindowsDir Condition="'$(ReactNativeWindowsDir)' == ''">$([MSBuild]::GetDirectoryNameOfFileAbove($(SolutionDir), 'node_modules\react-native-windows\package.json'))\node_modules\react-native-windows\</ReactNativeWindowsDir>
Expand Down Expand Up @@ -152,7 +150,6 @@
</Midl>
</ItemGroup>
<ItemGroup>
<None Include="examplenuget_TemporaryKey.pfx" />
<None Include="packages.config" />
<None Include="PropertySheet.props" />
<Text Include="readme.txt">
Expand Down
Binary file not shown.
Loading