Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove checked in pfx files #269

Closed
jonthysell opened this issue Feb 2, 2024 · 0 comments · Fixed by #275
Closed

Remove checked in pfx files #269

jonthysell opened this issue Feb 2, 2024 · 0 comments · Fixed by #275
Assignees
@jonthysell
Labels
enhancement New feature or request Status: In PR
Milestone
Backlog

Comments

@jonthysell
Copy link
Contributor

Summary

The example and examplenuget test apps have checked-in pfx files, which should be removed and instead injected during PR/CI time.

Motivation

WE shouldn't have pfx files checked in, even test-only ones.

Basic Example

We do this in the https://github.com/Microsoft/react-native-windows-samples repo, it shouldn't be too hard to replicate here.

Open Questions

No response
@jonthysell jonthysell added the enhancement New feature or request label Feb 2, 2024
@jonthysell jonthysell mentioned this issue Feb 2, 2024
Merged
jonthysell added a commit that referenced this issue Feb 2, 2024
@jonthysell
Refresh packaging test certs for examples (#270)
1a36e8c 
PR/CI are failing because the test certs expired for the example and
examplenuget packages. This PR refreshes then to unblock things.

This is just a temporary fix, technically we shouldn't have these files
checked-in at all. See #269
@jonthysell jonthysell added this to the Backlog milestone Feb 5, 2024
@jonthysell jonthysell self-assigned this Feb 5, 2024
@jonthysell jonthysell mentioned this issue Feb 15, 2024
Merged
jonthysell added a commit that referenced this issue Feb 15, 2024
@jonthysell
Remove example PFX files from repo (#275)
28c0c1f 
This PR removes the example PFX files in the repo and makes them
available to CI/PR if necessary.

Closes #269 

###### Microsoft Reviewers: [Open in
CodeFlow](https://microsoft.github.io/open-pr/?codeflow=https://github.com/microsoft/react-native-xaml/pull/275)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jonthysell jonthysell

Labels
enhancement New feature or request Status: In PR
Projects
None yet
Milestone
Backlog
Development

Successfully merging a pull request may close this issue.

Remove example PFX files from repo jonthysell/react-native-xaml
1 participant
@jonthysell