Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report errors in linking module #8844

Merged
3 commits merged into from
Oct 16, 2021
Merged

Conversation

asklar
Copy link
Member

@asklar asklar commented Oct 16, 2021

If an invalid url is passed, we'd crash; instead, report the error back to js
Fixes #8837

Microsoft Reviewers: Open in CodeFlow

@asklar asklar requested a review from a team as a code owner October 16, 2021 04:07
@asklar asklar added the AutoMerge Causes a PR to be automatically merged once all requirements are passed (label drives bot activity) label Oct 16, 2021
@ghost
Copy link

ghost commented Oct 16, 2021

Hello @asklar!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit 907119c into microsoft:main Oct 16, 2021
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AutoMerge Causes a PR to be automatically merged once all requirements are passed (label drives bot activity)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

openURL and canOpenURL crash the app if the argument is not a valid link
2 participants