Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for UIA accessibility landmarks #8708

Conversation

AgneLukoseviciute
Copy link
Contributor

@AgneLukoseviciute AgneLukoseviciute commented Sep 27, 2021

This adds a prop called accessibilityLandmarkType to View. This prop will wire to UIA LandmarkTypeProperty() and when used will allow for faster navigation & skimming by users interacting through a screen reader.

Microsoft Reviewers: Open in CodeFlow

@AgneLukoseviciute AgneLukoseviciute requested review from jonthysell and a team September 27, 2021 21:12
@ghost ghost added the Area: Accessibility label Sep 27, 2021
@asklar
Copy link
Member

asklar commented Sep 27, 2021

I see the referenced issue talks about Headings in addition to landmarks, but this PR only adds the latter. Are you planning on adding headings as well, or is that tracked by a separate PR/issue?

@AgneLukoseviciute
Copy link
Contributor Author

I see the referenced issue talks about Headings in addition to landmarks, but this PR only adds the latter. Are you planning on adding headings as well, or is that tracked by a separate PR/issue?

That was done separately a few weeks ago as it was a bit more urgent. (#8516)

@asklar
Copy link
Member

asklar commented Sep 27, 2021

I see the referenced issue talks about Headings in addition to landmarks, but this PR only adds the latter. Are you planning on adding headings as well, or is that tracked by a separate PR/issue?

That was done separately a few weeks ago as it was a bit more urgent. (#8516)

thanks @AgneLukoseviciute - could you also document that API then?

@AgneLukoseviciute
Copy link
Contributor Author

I see the referenced issue talks about Headings in addition to landmarks, but this PR only adds the latter. Are you planning on adding headings as well, or is that tracked by a separate PR/issue?

That was done separately a few weeks ago as it was a bit more urgent. (#8516)

thanks @AgneLukoseviciute - could you also document that API then?

Since that one didn't require a windows-specific prop, there wasn't a change to the API. Text now sets the heading level automatically whenever accessibilityRole="header" is specified to match RN-core, so I think we might be ok not documenting that as it was more of a bug fix.

@acoates-ms
Copy link
Contributor

Can we take a look at https://github.com/react-native-community/discussions-and-proposals/blob/fd64774e8161973b87b8f0a27587fa039eb7b43b/proposals/0000-accessibility-apis.md and see where this might fit in. Is there a gap in that proposal that we should be suggesting. Or should we be implementing this functionality in another way?

@AgneLukoseviciute
Copy link
Contributor Author

AgneLukoseviciute commented Sep 28, 2021

Can we take a look at https://github.com/react-native-community/discussions-and-proposals/blob/fd64774e8161973b87b8f0a27587fa039eb7b43b/proposals/0000-accessibility-apis.md and see where this might fit in. Is there a gap in that proposal that we should be suggesting. Or should we be implementing this functionality in another way?

@acoates-ms Thanks for pointing this out! It looks like there is an ARIA equivalent for UIA landmarks, and the RFC seems to be proposing that we do this through accessibilityRole. I'm now thinking this would be a better approach if having windows-specific values for accessibilityRole is not an issue.

I'll keep this open as I draft moving the logic over to accessibilityRole.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Accessibility] Add support for landmarks
3 participants