Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add todo stub for FacadeType::Progress in AnimatedNode #3544

Merged
merged 2 commits into from
Oct 31, 2019
Merged

Add todo stub for FacadeType::Progress in AnimatedNode #3544

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
63b6ab4
Change files
adamgorMSFT Oct 28, 2019
1adbc90
add issue number
adamgorMSFT Oct 28, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions change/react-native-windows-2019-10-28-12-46-31-user-adamgor-progress.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
{
"type": "prerelease",
"comment": "Add todo stub for FacadeType::Progress in AnimatedNode",
"packageName": "react-native-windows",
"email": "[email protected]",
"commit": "ce0f4a3a91e31207d2aa1691cfb55d159457e5d0",
"date": "2019-10-28T19:46:31.732Z",
"file": "F:\\GS\\repo\\RNW\\change\\react-native-windows-2019-10-28-12-46-31-user-adamgor-progress.json"
}
7 changes: 5 additions & 2 deletions vnext/ReactUWP/Modules/Animated/FacadeType.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ enum FacadeType {
TranslateX,
TranslateY,
Perspective,
Progress
};

static FacadeType StringToFacadeType(const std::string &string) {
Expand All @@ -37,7 +38,9 @@ static FacadeType StringToFacadeType(const std::string &string) {
return FacadeType::TranslateX;
if (string == "translateY")
return FacadeType::TranslateY;
if (string == "perspective")
return FacadeType::Perspective;

assert(string == "perspective");
return FacadeType::Perspective;
assert(string == "progress");
return FacadeType::Progress;
}
3 changes: 3 additions & 0 deletions vnext/ReactUWP/Modules/Animated/PropsAnimatedNode.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,6 +228,9 @@ void PropsAnimatedNode::MakeAnimation(int64_t valueNodeTag, FacadeType facadeTyp
case FacadeType::Perspective:
// TODO: implement perspective animations, tracked by issue #2680
return;
case FacadeType::Progress:
// TODO: implement progress animations, tracked by issue #3283
return;
default:
assert(false);
}
Expand Down