Exclude NuGet package lock files from NPM packages #13916
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vmoroz
approved these changes
Oct 3, 2024
marlenecota
approved these changes
Oct 3, 2024
jonthysell
added a commit
to jonthysell/react-native-windows
that referenced
this pull request
Oct 3, 2024
…13916) ## Description Removes the `packages.lock.json` and `packages.fabric.lock.json` files from our published NPM packages, as customers who choose to build M.RN themselves don't necessarily choose the same dependencies as us (such as SourceLink). ### Type of Change - Bug fix (non-breaking change which fixes an issue) ### Why See above. Resolves microsoft#13914 ### What Added filters to the NPM `package.json` files to exclude these lock files. ## Screenshots N/A ## Testing Verified with `npm pack` that new packages do not contain these files. ## Changelog Should this change be included in the release notes: _no_
jonthysell
added a commit
that referenced
this pull request
Oct 4, 2024
…13923) * [0.76] Exclude NuGet package lock files from NPM packages (#13916) ## Description Removes the `packages.lock.json` and `packages.fabric.lock.json` files from our published NPM packages, as customers who choose to build M.RN themselves don't necessarily choose the same dependencies as us (such as SourceLink). ### Type of Change - Bug fix (non-breaking change which fixes an issue) ### Why See above. Resolves #13914 ### What Added filters to the NPM `package.json` files to exclude these lock files. ## Screenshots N/A ## Testing Verified with `npm pack` that new packages do not contain these files. ## Changelog Should this change be included in the release notes: _no_
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes the
packages.lock.jsonandpackages.fabric.lock.jsonfiles from our published NPM packages, as customers who choose to build M.RN themselves don't necessarily choose the same dependencies as us (such as SourceLink).Type of Change
Why
See above.
Resolves #13914
What
Added filters to the NPM
package.jsonfiles to exclude these lock files.Screenshots
N/A
Testing
Verified with
npm packthat new packages do not contain these files.Changelog
Should this change be included in the release notes: no
Microsoft Reviewers: Open in CodeFlow