Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use babel-plugin-inline-view-configs once that package is published #5430

Open
acoates-ms opened this issue Jul 6, 2020 · 4 comments
Open
Labels
enhancement Workstream: ES Compliance SFI Provide regular ES infrastructure and ensure RNW meets internal security and compliance requirements
Milestone

Comments

@acoates-ms
Copy link
Contributor

We enable the babel-plugin-inline-view-configs internally to help detect mismatches between windows and core view managers.

Unfortunately babel-plugin-inline-view-configs is not yet published publicly, so we had to copy the files locally. This issue tracks the work to remove that copy, and use the publish package once its published.

@acoates-ms acoates-ms added the bug label Jul 6, 2020
@ghost ghost added the Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) label Jul 6, 2020
@chrisglein
Copy link
Member

once that package is published

When will that be? Sounds like around the timeline of Fabric, so a bit further out.

@chrisglein chrisglein removed the Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) label Jul 9, 2020
@chrisglein chrisglein added this to the Backlog milestone Jul 9, 2020
@rectified95
Copy link
Contributor

Checking in today, as I'm pulling in an update to babel-plugin-codegen/index.js
babel-plugin-inline-view-configs is still not in the NPM registry as of now

@Sunbreak
Copy link

facebook-github-bot pushed a commit to facebook/react-native that referenced this issue Sep 30, 2023
Summary:
`ScrollViewViewConfig.js` has been unused since [RN: Migrate ScrollView to NativeComponentRegistry](00e623d)

> Given to microsoft/react-native-windows#5430 (comment) `react-native/babel-plugin-codegen` has been part of `react-native/babel-preset`, it is safe to remove handwritten `ScrollViewViewConfig.js`

## Changelog:

[INTERNAL] [REMOVED] - Remove unused handwritten ScrollViewViewConfig.js

Pull Request resolved: #39655

Test Plan: None

Reviewed By: yungsters

Differential Revision: D49774632

Pulled By: dmytrorykun

fbshipit-source-id: a436d98f14d1e83f057a2ea4e96a527e759b80f1
@Saadnajmi
Copy link
Contributor

Hmm, anything special React Native macOS has to do to get the same detection? Or do we get it "for free" being a fork? ViewConfigs are still somewhat new to me for how they work.

@chiaramooney chiaramooney added the Workstream: ES Compliance SFI Provide regular ES infrastructure and ensure RNW meets internal security and compliance requirements label Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Workstream: ES Compliance SFI Provide regular ES infrastructure and ensure RNW meets internal security and compliance requirements
Projects
None yet
Development

No branches or pull requests

6 participants