-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use babel-plugin-inline-view-configs once that package is published #5430
Comments
When will that be? Sounds like around the timeline of Fabric, so a bit further out. |
Checking in today, as I'm pulling in an update to |
|
Summary: `ScrollViewViewConfig.js` has been unused since [RN: Migrate ScrollView to NativeComponentRegistry](00e623d) > Given to microsoft/react-native-windows#5430 (comment) `react-native/babel-plugin-codegen` has been part of `react-native/babel-preset`, it is safe to remove handwritten `ScrollViewViewConfig.js` ## Changelog: [INTERNAL] [REMOVED] - Remove unused handwritten ScrollViewViewConfig.js Pull Request resolved: #39655 Test Plan: None Reviewed By: yungsters Differential Revision: D49774632 Pulled By: dmytrorykun fbshipit-source-id: a436d98f14d1e83f057a2ea4e96a527e759b80f1
Hmm, anything special React Native macOS has to do to get the same detection? Or do we get it "for free" being a fork? ViewConfigs are still somewhat new to me for how they work. |
We enable the
babel-plugin-inline-view-configs
internally to help detect mismatches between windows and core view managers.Unfortunately
babel-plugin-inline-view-configs
is not yet published publicly, so we had to copy the files locally. This issue tracks the work to remove that copy, and use the publish package once its published.The text was updated successfully, but these errors were encountered: