-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
App publication to store refused due to "Supported API Test" issue #4475
Comments
Any news on this issue ? I would really appreciate any help on this. Could it be linked to the version of Visual Studio I'm using ? I apply the updates as soon as they are released. Is that a bad practice ? Do you have automatic tests for release certification ? and if so do they pass ? Thank you again for this great repo and for investing so much resources in it, I know you have a lot to deal with. |
@giregk It looks like all of those errors are related to V8. Did you switch your JavaScript engine from Chakra to V8? We've had some apps publish to the store but I don't know if we've had one go up with V8 or not. Chakra is still the default as that we haven't signed off on V8 yet as being ship ready. |
@chrisglein thank you for your quick response. That does not ring a bell, I don't remember doing any such change. Thank you for the advice, I will investigate in this direction. |
It appears V8 is enable by default as explained in this issue and as can be seen in PropertySheets/React.Cpp.props since the I tried to comment this line / set this value to false, then clean and rebuilt project but I still get the same error. |
Can you try removing v8jsi.dll / v8jsi.pdb from your app package? The library is delay-loaded and unneeded unless you turn on the corresponding code path (at runtime), which is disabled by default. A clean build with USE_V8 set to false should no longer include v8jsi.dll in the build outputs. Perhaps try manually cleaning the build outputs and doing another clean build. |
Thanks @tudorms for your help. Actually it works. Setting USE_V8 to false indeed removes the error. I thought it didn't work because now I have a similar error with react-native-webview and I had not read it in details. Do you want me to close this issue or do you want me to keep it open ? |
So I've tried to apply the patch to my RNWTestRelease project which is a virgin project without any change after initialisation. I get this error But according to microsoft/microsoft-ui-xaml#1446, this was partially fixed and now only occurs in the local Windows App Certification Kit but is fine on the store. |
I opened a similar issue caused by having a custom C# native module. |
Seems like the immediate course of action here is to fix V8 not being the default and have no side effects for certification if you're not using V8. @tudorms is looking into this. |
Adding must-have to this since it blocks shipping to the store without undocumented manual intervention. |
* Disable copying V8 dll to target output; we need a clearer way to distinguish uwp vs. win32 in the build system but this will do for now to unblock #4475 * Change files Co-authored-by: tudorm <[email protected]>
Environment
If you are using latest version:
react-native -v
:react-native-cli: 2.0.1
react-native: 0.61.5
react-native run-windows --info
:System:
OS: Windows 10 10.0.18362
CPU: (4) ia32 Intel(R) Core(TM) i7-7500U CPU @ 2.70GHz
Memory: 2.98 GB / 7.92 GB
Binaries:
Node: 12.1.0 - C:\Program Files (x86)\nodejs\node.EXE
Yarn: 1.16.0 - C:\Program Files (x86)\Yarn\bin\yarn.CMD
npm: 6.9.0 - C:\Program Files (x86)\nodejs\npm.CMD
npmPackages:
react: 16.9.0 => 16.9.0
react-native: ^0.61.5 => 0.61.5
react-native-windows: 0.61.0 => 0.61.0
rnpm-plugin-windows: ^0.5.1-0 => 0.5.1-0
Installed UWP SDKs:
10.0.14393.0
10.0.17763.0
10.0.18362.0
Steps to Reproduce
Expected Behavior
The Windows App Certification Kit should say the app is OK.
Actual Behavior
The Certification report has the following "Supported API test" issue
Additional context
This also happens on the microsoft store if I upload the package and submit the app for review.
The text was updated successfully, but these errors were encountered: