Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App publication to store refused due to "Supported API Test" issue #4475

Closed
giregk opened this issue Apr 2, 2020 · 11 comments
Closed

App publication to store refused due to "Supported API Test" issue #4475

giregk opened this issue Apr 2, 2020 · 11 comments

Comments

@giregk
Copy link

giregk commented Apr 2, 2020

Environment

If you are using latest version:

  1. react-native -v:
    react-native-cli: 2.0.1
    react-native: 0.61.5
  2. react-native run-windows --info:
    System:
    OS: Windows 10 10.0.18362
    CPU: (4) ia32 Intel(R) Core(TM) i7-7500U CPU @ 2.70GHz
    Memory: 2.98 GB / 7.92 GB
    Binaries:
    Node: 12.1.0 - C:\Program Files (x86)\nodejs\node.EXE
    Yarn: 1.16.0 - C:\Program Files (x86)\Yarn\bin\yarn.CMD
    npm: 6.9.0 - C:\Program Files (x86)\nodejs\npm.CMD
    npmPackages:
    react: 16.9.0 => 16.9.0
    react-native: ^0.61.5 => 0.61.5
    react-native-windows: 0.61.0 => 0.61.0
    rnpm-plugin-windows: ^0.5.1-0 => 0.5.1-0
    Installed UWP SDKs:
    10.0.14393.0
    10.0.17763.0
    10.0.18362.0
  • Target Platform Version(s): 10.0.18362
  • Target Device(s): Desktop
  • Visual Studio Version: 2019
  • Build Configuration: ReleaseBundle

Steps to Reproduce

  1. npx react-native init RNWTestRelease --version ^0.61.5
  2. yarn add rnpm-plugin-windows --dev
  3. npx react-native windows
  4. VS2019 > Project > Publish > Associate app with the store ...
  5. VS2019 > Project > Publish > Create app packages
    • x86
    • x64
    • ARM

Expected Behavior

The Windows App Certification Kit should say the app is OK.

Actual Behavior

The Certification report has the following "Supported API test" issue

API _CxxThrowException in vcruntime140.dll is not supported for this application type. v8jsi.dll calls this API.
API __C_specific_handler in vcruntime140.dll is not supported for this application type. v8jsi.dll calls this API.
API __CxxFrameHandler3 in vcruntime140.dll is not supported for this application type. v8jsi.dll calls this API.
API __current_exception in vcruntime140.dll is not supported for this application type. v8jsi.dll calls this API.
API __current_exception_context in vcruntime140.dll is not supported for this application type. v8jsi.dll calls this API.
API __std_exception_copy in vcruntime140.dll is not supported for this application type. v8jsi.dll calls this API.
API __std_exception_destroy in vcruntime140.dll is not supported for this application type. v8jsi.dll calls this API.
API __std_terminate in vcruntime140.dll is not supported for this application type. v8jsi.dll calls this API.
API __std_type_info_compare in vcruntime140.dll is not supported for this application type. v8jsi.dll calls this API.
API __std_type_info_destroy_list in vcruntime140.dll is not supported for this application type. v8jsi.dll calls this API.
API _purecall in vcruntime140.dll is not supported for this application type. v8jsi.dll calls this API.
API memchr in vcruntime140.dll is not supported for this application type. v8jsi.dll calls this API.
API memcmp in vcruntime140.dll is not supported for this application type. v8jsi.dll calls this API.
API memcpy in vcruntime140.dll is not supported for this application type. v8jsi.dll calls this API.
API memmove in vcruntime140.dll is not supported for this application type. v8jsi.dll calls this API.
API memset in vcruntime140.dll is not supported for this application type. v8jsi.dll calls this API.
API strchr in vcruntime140.dll is not supported for this application type. v8jsi.dll calls this API.
API ??0?$basic_ios@DU?$char_traits@D@std@@@std@@IEAA@XZ in msvcp140.dll is not supported for this application type. v8jsi.dll calls this API.
API ??0?$basic_ios@DU?$char_traits@D@std@@@std@@QEAA@PEAV?$basic_streambuf@DU?$char_traits@D@std@@@1@@Z in msvcp140.dll is not supported for this application type. v8jsi.dll calls this API.
API ??0?$basic_iostream@DU?$char_traits@D@std@@@std@@QEAA@PEAV?$basic_streambuf@DU?$char_traits@D@std@@@1@@Z in msvcp140.dll is not supported for this application type. v8jsi.dll calls this API.
API ??0?$basic_ostream@DU?$char_traits@D@std@@@std@@QEAA@PEAV?$basic_streambuf@DU?$char_traits@D@std@@@1@_N@Z in msvcp140.dll is not supported for this application type. v8jsi.dll calls this API.
API ??0?$basic_streambuf@DU?$char_traits@D@std@@@std@@IEAA@XZ in msvcp140.dll is not supported for this application type. v8jsi.dll calls this API.
API ??0_Lockit@std@@QEAA@H@Z in msvcp140.dll is not supported for this application type. v8jsi.dll calls this API.
API ??1?$basic_ios@DU?$char_traits@D@std@@@std@@UEAA@XZ in msvcp140.dll is not supported for this application type. v8jsi.dll calls this API.
API ??1?$basic_iostream@DU?$char_traits@D@std@@@std@@UEAA@XZ in msvcp140.dll is not supported for this application type. v8jsi.dll calls this API.
API ??1?$basic_ostream@DU?$char_traits@D@std@@@std@@UEAA@XZ in msvcp140.dll is not supported for this application type. v8jsi.dll calls this API.
API ??1?$basic_streambuf@DU?$char_traits@D@std@@@std@@UEAA@XZ in msvcp140.dll is not supported for this application type. v8jsi.dll calls this API.
API ??1_Lockit@std@@QEAA@XZ in msvcp140.dll is not supported for this application type. v8jsi.dll calls this API.
API ??6?$basic_ostream@DU?$char_traits@D@std@@@std@@QEAAAEAV01@F@Z in msvcp140.dll is not supported for this application type. v8jsi.dll calls this API.
API ??6?$basic_ostream@DU?$char_traits@D@std@@@std@@QEAAAEAV01@H@Z in msvcp140.dll is not supported for this application type. v8jsi.dll calls this API.
API ??6?$basic_ostream@DU?$char_traits@D@std@@@std@@QEAAAEAV01@I@Z in msvcp140.dll is not supported for this application type. v8jsi.dll calls this API.
API ??6?$basic_ostream@DU?$char_traits@D@std@@@std@@QEAAAEAV01@K@Z in msvcp140.dll is not supported for this application type. v8jsi.dll calls this API.
API ??6?$basic_ostream@DU?$char_traits@D@std@@@std@@QEAAAEAV01@M@Z in msvcp140.dll is not supported for this application type. v8jsi.dll calls this API.
API ??6?$basic_ostream@DU?$char_traits@D@std@@@std@@QEAAAEAV01@N@Z in msvcp140.dll is not supported for this application type. v8jsi.dll calls this API.
API ??6?$basic_ostream@DU?$char_traits@D@std@@@std@@QEAAAEAV01@P6AAEAV01@AEAV01@@Z@Z in msvcp140.dll is not supported for this application type. v8jsi.dll calls this API.
API ??6?$basic_ostream@DU?$char_traits@D@std@@@std@@QEAAAEAV01@P6AAEAVios_base@1@AEAV21@@Z@Z in msvcp140.dll is not supported for this application type. v8jsi.dll calls this API.
API ??6?$basic_ostream@DU?$char_traits@D@std@@@std@@QEAAAEAV01@PEBX@Z in msvcp140.dll is not supported for this application type. v8jsi.dll calls this API.
API ??6?$basic_ostream@DU?$char_traits@D@std@@@std@@QEAAAEAV01@_J@Z in msvcp140.dll is not supported for this application type. v8jsi.dll calls this API.
API ??6?$basic_ostream@DU?$char_traits@D@std@@@std@@QEAAAEAV01@_K@Z in msvcp140.dll is not supported for this application type. v8jsi.dll calls this API.
API ??6?$basic_ostream@DU?$char_traits@D@std@@@std@@QEAAAEAV01@_N@Z in msvcp140.dll is not supported for this application type. v8jsi.dll calls this API.
API ??Bid@locale@std@@QEAA_KXZ in msvcp140.dll is not supported for this application type. v8jsi.dll calls this API.
API ?_Fiopen@std@@YAPEAU_iobuf@@PEBDHH@Z in msvcp140.dll is not supported for this application type. v8jsi.dll calls this API.
API ?_Getcat@?$codecvt@DDU_Mbstatet@@@std@@SA_KPEAPEBVfacet@locale@2@PEBV42@@Z in msvcp140.dll is not supported for this application type. v8jsi.dll calls this API.
API ?_Getgloballocale@locale@std@@CAPEAV_Locimp@12@XZ in msvcp140.dll is not supported for this application type. v8jsi.dll calls this API.
API ?_Gninc@?$basic_streambuf@DU?$char_traits@D@std@@@std@@IEAAPEADXZ in msvcp140.dll is not supported for this application type. v8jsi.dll calls this API.
API ?_Init@?$basic_streambuf@DU?$char_traits@D@std@@@std@@IEAAXPEAPEAD0PEAH001@Z in msvcp140.dll is not supported for this application type. v8jsi.dll calls this API.
API ?_Init@?$basic_streambuf@DU?$char_traits@D@std@@@std@@IEAAXXZ in msvcp140.dll is not supported for this application type. v8jsi.dll calls this API.
API ?_Ipfx@?$basic_istream@DU?$char_traits@D@std@@@std@@QEAA_N_N@Z in msvcp140.dll is not supported for this application type. v8jsi.dll calls this API.
API ?_Lock@?$basic_streambuf@DU?$char_traits@D@std@@@std@@UEAAXXZ in msvcp140.dll is not supported for this application type. v8jsi.dll calls this API.
API ?_Osfx@?$basic_ostream@DU?$char_traits@D@std@@@std@@QEAAXXZ in msvcp140.dll is not supported for this application type. v8jsi.dll calls this API.
API ?_Pninc@?$basic_streambuf@DU?$char_traits@D@std@@@std@@IEAAPEADXZ in msvcp140.dll is not supported for this application type. v8jsi.dll calls this API.
API ?_Random_device@std@@YAIXZ in msvcp140.dll is not supported for this application type. v8jsi.dll calls this API.
API ?_Throw_C_error@std@@YAXH@Z in msvcp140.dll is not supported for this application type. v8jsi.dll calls this API.
API ?_Throw_Cpp_error@std@@YAXH@Z in msvcp140.dll is not supported for this application type. v8jsi.dll calls this API.
API ?_Unlock@?$basic_streambuf@DU?$char_traits@D@std@@@std@@UEAAXXZ in msvcp140.dll is not supported for this application type. v8jsi.dll calls this API.
API ?_Xbad_alloc@std@@YAXXZ in msvcp140.dll is not supported for this application type. v8jsi.dll calls this API.
API ?_Xbad_function_call@std@@YAXXZ in msvcp140.dll is not supported for this application type. v8jsi.dll calls this API.
API ?_Xlength_error@std@@YAXPEBD@Z in msvcp140.dll is not supported for this application type. v8jsi.dll calls this API.
API ?_Xout_of_range@std@@YAXPEBD@Z in msvcp140.dll is not supported for this application type. v8jsi.dll calls this API.
API ?_Xoverflow_error@std@@YAXPEBD@Z in msvcp140.dll is not supported for this application type. v8jsi.dll calls this API.
API ?always_noconv@codecvt_base@std@@QEBA_NXZ in msvcp140.dll is not supported for this application type. v8jsi.dll calls this API.
API ?cerr@std@@3V?$basic_ostream@DU?$char_traits@D@std@@@1@A in msvcp140.dll is not supported for this application type. v8jsi.dll calls this API.
API ?copyfmt@?$basic_ios@DU?$char_traits@D@std@@@std@@QEAAAEAV12@AEBV12@@Z in msvcp140.dll is not supported for this application type. v8jsi.dll calls this API.
API ?cout@std@@3V?$basic_ostream@DU?$char_traits@D@std@@@1@A in msvcp140.dll is not supported for this application type. v8jsi.dll calls this API.
API ?flush@?$basic_ostream@DU?$char_traits@D@std@@@std@@QEAAAEAV12@XZ in msvcp140.dll is not supported for this application type. v8jsi.dll calls this API.
API ?gbump@?$basic_streambuf@DU?$char_traits@D@std@@@std@@IEAAXH@Z in msvcp140.dll is not supported for this application type. v8jsi.dll calls this API.
API ?getloc@?$basic_streambuf@DU?$char_traits@D@std@@@std@@QEBA?AVlocale@2@XZ in msvcp140.dll is not supported for this application type. v8jsi.dll calls this API.
API ?id@?$codecvt@DDU_Mbstatet@@@std@@2V0locale@2@A in msvcp140.dll is not supported for this application type. v8jsi.dll calls this API.
API ?imbue@?$basic_streambuf@DU?$char_traits@D@std@@@std@@MEAAXAEBVlocale@2@@Z in msvcp140.dll is not supported for this application type. v8jsi.dll calls this API.
API ?in@?$codecvt@DDU_Mbstatet@@@std@@QEBAHAEAU_Mbstatet@@PEBD1AEAPEBDPEAD3AEAPEAD@Z in msvcp140.dll is not supported for this application type. v8jsi.dll calls this API.
API ?out@?$codecvt@DDU_Mbstatet@@@std@@QEBAHAEAU_Mbstatet@@PEBD1AEAPEBDPEAD3AEAPEAD@Z in msvcp140.dll is not supported for this application type. v8jsi.dll calls this API.
API ?pbackfail@?$basic_streambuf@DU?$char_traits@D@std@@@std@@MEAAHH@Z in msvcp140.dll is not supported for this application type. v8jsi.dll calls this API.
API ?put@?$basic_ostream@DU?$char_traits@D@std@@@std@@QEAAAEAV12@D@Z in msvcp140.dll is not supported for this application type. v8jsi.dll calls this API.
API ?rdbuf@?$basic_ios@DU?$char_traits@D@std@@@std@@QEAAPEAV?$basic_streambuf@DU?$char_traits@D@std@@@2@PEAV32@@Z in msvcp140.dll is not supported for this application type. v8jsi.dll calls this API.
API ?sbumpc@?$basic_streambuf@DU?$char_traits@D@std@@@std@@QEAAHXZ in msvcp140.dll is not supported for this application type. v8jsi.dll calls this API.
API ?seekoff@?$basic_streambuf@DU?$char_traits@D@std@@@std@@MEAA?AV?$fpos@U_Mbstatet@@@2@_JHH@Z in msvcp140.dll is not supported for this application type. v8jsi.dll calls this API.
API ?seekpos@?$basic_streambuf@DU?$char_traits@D@std@@@std@@MEAA?AV?$fpos@U_Mbstatet@@@2@V32@H@Z in msvcp140.dll is not supported for this application type. v8jsi.dll calls this API.
API ?setbuf@?$basic_streambuf@DU?$char_traits@D@std@@@std@@MEAAPEAV12@PEAD_J@Z in msvcp140.dll is not supported for this application type. v8jsi.dll calls this API.
API ?setprecision@std@@YA?AU?$_Smanip@_J@1@_J@Z in msvcp140.dll is not supported for this application type. v8jsi.dll calls this API.
API ?setstate@?$basic_ios@DU?$char_traits@D@std@@@std@@QEAAXH_N@Z in msvcp140.dll is not supported for this application type. v8jsi.dll calls this API.
API ?setw@std@@YA?AU?$_Smanip@_J@1@_J@Z in msvcp140.dll is not supported for this application type. v8jsi.dll calls this API.
API ?sgetc@?$basic_streambuf@DU?$char_traits@D@std@@@std@@QEAAHXZ in msvcp140.dll is not supported for this application type. v8jsi.dll calls this API.
API ?showmanyc@?$basic_streambuf@DU?$char_traits@D@std@@@std@@MEAA_JXZ in msvcp140.dll is not supported for this application type. v8jsi.dll calls this API.
API ?snextc@?$basic_streambuf@DU?$char_traits@D@std@@@std@@QEAAHXZ in msvcp140.dll is not supported for this application type. v8jsi.dll calls this API.
API ?sputc@?$basic_streambuf@DU?$char_traits@D@std@@@std@@QEAAHD@Z in msvcp140.dll is not supported for this application type. v8jsi.dll calls this API.
API ?sputn@?$basic_streambuf@DU?$char_traits@D@std@@@std@@QEAA_JPEBD_J@Z in msvcp140.dll is not supported for this application type. v8jsi.dll calls this API.
API ?sync@?$basic_streambuf@DU?$char_traits@D@std@@@std@@MEAAHXZ in msvcp140.dll is not supported for this application type. v8jsi.dll calls this API.
API ?uflow@?$basic_streambuf@DU?$char_traits@D@std@@@std@@MEAAHXZ in msvcp140.dll is not supported for this application type. v8jsi.dll calls this API.
API ?uncaught_exception@std@@YA_NXZ in msvcp140.dll is not supported for this application type. v8jsi.dll calls this API.
API ?underflow@?$basic_streambuf@DU?$char_traits@D@std@@@std@@MEAAHXZ in msvcp140.dll is not supported for this application type. v8jsi.dll calls this API.
API ?unshift@?$codecvt@DDU_Mbstatet@@@std@@QEBAHAEAU_Mbstatet@@PEAD1AEAPEAD@Z in msvcp140.dll is not supported for this application type. v8jsi.dll calls this API.
API ?widen@?$basic_ios@DU?$char_traits@D@std@@@std@@QEBADD@Z in msvcp140.dll is not supported for this application type. v8jsi.dll calls this API.
API ?write@?$basic_ostream@DU?$char_traits@D@std@@@std@@QEAAAEAV12@PEBD_J@Z in msvcp140.dll is not supported for this application type. v8jsi.dll calls this API.
API ?xsgetn@?$basic_streambuf@DU?$char_traits@D@std@@@std@@MEAA_JPEAD_J@Z in msvcp140.dll is not supported for this application type. v8jsi.dll calls this API.
API ?xsputn@?$basic_streambuf@DU?$char_traits@D@std@@@std@@MEAA_JPEBD_J@Z in msvcp140.dll is not supported for this application type. v8jsi.dll calls this API.
API _Cnd_broadcast in msvcp140.dll is not supported for this application type. v8jsi.dll calls this API.
API _Cnd_destroy_in_situ in msvcp140.dll is not supported for this application type. v8jsi.dll calls this API.
API _Cnd_do_broadcast_at_thread_exit in msvcp140.dll is not supported for this application type. v8jsi.dll calls this API.
API _Cnd_init_in_situ in msvcp140.dll is not supported for this application type. v8jsi.dll calls this API.
API _Cnd_wait in msvcp140.dll is not supported for this application type. v8jsi.dll calls this API.
API _Mtx_destroy_in_situ in msvcp140.dll is not supported for this application type. v8jsi.dll calls this API.
API _Mtx_init_in_situ in msvcp140.dll is not supported for this application type. v8jsi.dll calls this API.
API _Mtx_lock in msvcp140.dll is not supported for this application type. v8jsi.dll calls this API.
API _Mtx_unlock in msvcp140.dll is not supported for this application type. v8jsi.dll calls this API.
API _Thrd_detach in msvcp140.dll is not supported for this application type. v8jsi.dll calls this API.
API _Xtime_get_ticks in msvcp140.dll is not supported for this application type. v8jsi.dll calls this API.
API RtlAddFunctionTable in kernel32.dll is not supported for this application type. v8jsi.dll calls this API.
API RtlDeleteFunctionTable in kernel32.dll is not supported for this application type. v8jsi.dll calls this API.
API StackWalk64 in dbghelp.dll is not supported for this application type. v8jsi.dll calls this API.
API SymFromAddr in dbghelp.dll is not supported for this application type. v8jsi.dll calls this API.
API SymFunctionTableAccess64 in dbghelp.dll is not supported for this application type. v8jsi.dll calls this API.
API SymGetLineFromAddr64 in dbghelp.dll is not supported for this application type. v8jsi.dll calls this API.
API SymGetModuleBase64 in dbghelp.dll is not supported for this application type. v8jsi.dll calls this API.
API SymGetSearchPathW in dbghelp.dll is not supported for this application type. v8jsi.dll calls this API.
API SymInitialize in dbghelp.dll is not supported for this application type. v8jsi.dll calls this API.
API SymSetOptions in dbghelp.dll is not supported for this application type. v8jsi.dll calls this API.
API SymSetSearchPathW in dbghelp.dll is not supported for this application type. v8jsi.dll calls this API.
API __CxxFrameHandler4 in vcruntime140_1_app.dll is not supported for this application type. RNWTestRelease.exe calls this API.

image

Additional context

This also happens on the microsoft store if I upload the package and submit the app for review.

@giregk giregk added the bug label Apr 2, 2020
@ghost ghost added the Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) label Apr 2, 2020
@giregk
Copy link
Author

giregk commented Apr 6, 2020

Any news on this issue ? I would really appreciate any help on this.
Do other people face the same issue or is it just me ? Any ideas, even untested ?

Could it be linked to the version of Visual Studio I'm using ? I apply the updates as soon as they are released. Is that a bad practice ?

Do you have automatic tests for release certification ? and if so do they pass ?

Thank you again for this great repo and for investing so much resources in it, I know you have a lot to deal with.

@chrisglein
Copy link
Member

@giregk It looks like all of those errors are related to V8. Did you switch your JavaScript engine from Chakra to V8? We've had some apps publish to the store but I don't know if we've had one go up with V8 or not. Chakra is still the default as that we haven't signed off on V8 yet as being ship ready.

@chrisglein chrisglein added Needs: Author Feedback The issue/PR needs activity from its author (label drives bot activity) and removed Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) labels Apr 6, 2020
@giregk
Copy link
Author

giregk commented Apr 6, 2020

@chrisglein thank you for your quick response. That does not ring a bell, I don't remember doing any such change. Thank you for the advice, I will investigate in this direction.

@ghost ghost added Needs: Attention 👋 An issue that had been tagged "Needs: Author Feedback" has received activity (label applied by bot) and removed Needs: Author Feedback The issue/PR needs activity from its author (label drives bot activity) labels Apr 6, 2020
@giregk
Copy link
Author

giregk commented Apr 6, 2020

It appears V8 is enable by default as explained in this issue and as can be seen in PropertySheets/React.Cpp.props since the USE_V8 property is set to true for non-ARM platforms.

I tried to comment this line / set this value to false, then clean and rebuilt project but I still get the same error.

@tudorms
Copy link
Member

tudorms commented Apr 6, 2020

Can you try removing v8jsi.dll / v8jsi.pdb from your app package? The library is delay-loaded and unneeded unless you turn on the corresponding code path (at runtime), which is disabled by default.

A clean build with USE_V8 set to false should no longer include v8jsi.dll in the build outputs. Perhaps try manually cleaning the build outputs and doing another clean build.

@giregk
Copy link
Author

giregk commented Apr 7, 2020

Thanks @tudorms for your help. Actually it works. Setting USE_V8 to false indeed removes the error. I thought it didn't work because now I have a similar error with react-native-webview and I had not read it in details.

Do you want me to close this issue or do you want me to keep it open ?

@giregk
Copy link
Author

giregk commented Apr 7, 2020

So I've tried to apply the patch to my RNWTestRelease project which is a virgin project without any change after initialisation. I get this error
API __CxxFrameHandler4 in vcruntime140_1_app.dll is not supported for this application type. RNWTestRelease.exe calls this API.

But according to microsoft/microsoft-ui-xaml#1446, this was partially fixed and now only occurs in the local Windows App Certification Kit but is fine on the store.

@giregk
Copy link
Author

giregk commented Apr 7, 2020

I opened a similar issue caused by having a custom C# native module.
#4516

@chrisglein chrisglein added Area: JavaScript Engine and removed Needs: Attention 👋 An issue that had been tagged "Needs: Author Feedback" has received activity (label applied by bot) labels Apr 9, 2020
@chrisglein chrisglein added this to the 0.62 (M5) milestone Apr 9, 2020
@chrisglein
Copy link
Member

Seems like the immediate course of action here is to fix V8 not being the default and have no side effects for certification if you're not using V8. @tudorms is looking into this.

@NickGerleman
Copy link
Collaborator

Adding must-have to this since it blocks shipping to the store without undocumented manual intervention.

tudorms added a commit that referenced this issue Apr 25, 2020
* Disable copying V8 dll to target output; we need a clearer way to distinguish uwp vs. win32 in the build system but this will do for now to unblock #4475

* Change files

Co-authored-by: tudorm <[email protected]>
@asklar
Copy link
Member

asklar commented Jun 28, 2020

related: #5362 #5365

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants