Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

react-native-cli hooks for UWP #4

Closed
rozele opened this issue Dec 15, 2015 · 3 comments
Closed

react-native-cli hooks for UWP #4

rozele opened this issue Dec 15, 2015 · 3 comments
Labels
must-have p1
Milestone
Developer Experience

Comments

@rozele
Copy link
Collaborator

rozele commented Dec 15, 2015 •
edited
Loading

Investigate what react-native-cli does for other projects and replicate for UWP.
@erikschlegel erikschlegel added this to the Command Line Interface milestone Dec 28, 2015
@rozele rozele modified the milestones: Developer Support, Command Line Interface Feb 18, 2016
@rozele
Copy link
Collaborator Author

rozele commented Mar 9, 2016

This issue is now more narrowly targeted at implementing a runWindows command for the CLI.

@rozele rozele changed the title react-native-cli hooks for UWP Add RN CLI option to run-windows platform Mar 9, 2016
@rozele rozele changed the title Add RN CLI option to run-windows platform Add RN CLI option to "runWindows" Mar 9, 2016
@rozele rozele changed the title Add RN CLI option to "runWindows" react-native-cli hooks for UWP Mar 9, 2016
@rozele rozele added ready and removed ready labels Mar 9, 2016
@rozele
Copy link
Collaborator Author

rozele commented Mar 10, 2016

Some other things to keep in mind here. Certain tools, like VS Code, will need hooks to ensure that we launch the app in "debug in Chrome" mode so that it connects to the debugger, rather than runs JavaScript locally.

Also, we'll need a couple additional CLI flags to differentiate between launching on the desktop, launching on an attached device, or deploying to an emulator.

@rozele rozele added the ready label Mar 10, 2016
@rozele rozele removed the ready label Mar 25, 2016
@grabbou
Copy link

grabbou commented Apr 14, 2016 •
edited
Loading

Hey,

Amazing work so far! Just wanted to say I'm ready to help on adding some missing modules like AppState etc. - might be a good moment to refresh my C# & Windows episode.

Back to the issue... we are working on getting rnpm merged into react-native and use some of its internals which means the plug-in system should land there eventually. That would make it possible to dynamically define extra commands, like runWindows or whatever else we may came up with in the future. Not sure if that fits well here since it's just a fork, but I've seen this topic mentioned briefly on our Facebook group so thought I am going to find related issue in the project itself!

Here's the link to current way it's working:
https://github.com/rnpm/rnpm#plugins

cc: @mkonicek

@rozele rozele added the ready label Apr 21, 2016
@rozele rozele mentioned this issue Apr 29, 2016
Closed
@rozele rozele added in progress and removed ready labels Jun 28, 2016
@rozele rozele closed this as completed Jun 28, 2016
@pre10der89 pre10der89 mentioned this issue Jul 27, 2018
Closed
randy-flynn added a commit that referenced this issue Apr 4, 2019
@randy-flynn
Merge pull request #4 from Microsoft/rnwcpp-preview
83f6beb 
Rnwcpp preview
ghost pushed a commit that referenced this issue Jul 30, 2020
@asklar
WinUI 3/islands support (#5576)
958ebb9 
* Squash changes for IXP winui3 nuget  (#4)

* Playground Win32 - start getting it working on WinUI 3

* Change files

* use lifted DWXS

* DWXS header

* create separate 16.7 packaging solution

* format

* fix non-winui3 case

* use CI nuget downloaded and expanded to C:\temp

* preprocessor defines

* Port to WinUI 3 dev nuget with IXP payload (almost preview 2). Islands are rendering!

* hosting namespace

* Playground Win32 - start getting it working on WinUI 3

* DWXS header

* create separate 16.7 packaging solution

* format

* guard against hresult (from failed activation) in UIManager, update reference to winui.props in WAP

* Playground Win32 - start getting it working on WinUI 3

* DWXS header

* create separate 16.7 packaging solution

* format

* Port to WinUI 3 dev nuget with IXP payload (almost preview 2). Islands are rendering!

* Playground Win32 - start getting it working on WinUI 3

* use lifted DWXS

* DWXS header

* create separate 16.7 packaging solution

* format

* guard against hresult (from failed activation) in UIManager, update reference to winui.props in WAP

* Playground Win32 - start getting it working on WinUI 3

* DWXS header

* create separate 16.7 packaging solution

* format

* Port to WinUI 3 dev nuget with IXP payload (almost preview 2). Islands are rendering!

* Squash changes for IXP winui3 nuget  (#4)

* Playground Win32 - start getting it working on WinUI 3

* Change files

* use lifted DWXS

* DWXS header

* create separate 16.7 packaging solution

* format

* fix non-winui3 case

* use CI nuget downloaded and expanded to C:\temp

* preprocessor defines

* Port to WinUI 3 dev nuget with IXP payload (almost preview 2). Islands are rendering!

* hosting namespace

* Playground Win32 - start getting it working on WinUI 3

* DWXS header

* create separate 16.7 packaging solution

* format

* guard against hresult (from failed activation) in UIManager, update reference to winui.props in WAP

* Playground Win32 - start getting it working on WinUI 3

* DWXS header

* create separate 16.7 packaging solution

* format

* Port to WinUI 3 dev nuget with IXP payload (almost preview 2). Islands are rendering!

* Playground Win32 - start getting it working on WinUI 3

* use lifted DWXS

* DWXS header

* create separate 16.7 packaging solution

* format

* guard against hresult (from failed activation) in UIManager, update reference to winui.props in WAP

* Playground Win32 - start getting it working on WinUI 3

* DWXS header

* create separate 16.7 packaging solution

* format

* Port to WinUI 3 dev nuget with IXP payload (almost preview 2). Islands are rendering!

* restore preview 2 nugets, and a script to transmogriphy until preview 3 is out

* IXP experimental APIs in preview 3

* format

* PR feedback

* format

* fix encoding, format

* encoding

* encoding
kmelmon added a commit that referenced this issue Aug 18, 2020
@kmelmon
Re-enable VisitAllPages E2ETest (#5699)
4174941 
* re-enable

* comment out PlatformColor test, this was the failing test in the past as well

* trying again, this time commenting out PanResponder Sample, which comes just before the failing test

* trying to wait for home page to load before continuing

* another take on waiting for item in FlatList to be loaded first

* trying new approach, enter test name in edit box to filter first

* made some progress, now timing out on edit control, add polling for that control

* finally!  success.  Try #2

* try #3, fingers crossed!

* try #4

* split test into groups

* bumping up timeout

* try #2 with longer timeout

* go back to one testspec

* try #4 with longer timeout

* try #5 with longer timeout.  really folks I think I got it this time :)

* convert all the tests to use same mechanism

* Change files

* remove smoke test

* stability pass after removing smoke test, try #2
FalseLobster pushed a commit to FalseLobster/react-native-windows that referenced this issue Mar 22, 2022
@rurikoaraki
Merge pull request microsoft#4 from acoates-ms/text_wincomp_color
b463b39 
Implement color on fragments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
must-have p1
Projects
None yet
Milestone
Developer Experience
Development

No branches or pull requests
4 participants
@rozele @grabbou @erikschlegel @mpodwysocki