Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

react-native-windows interop with WinUI 3.0 #2492

Closed
jesbis opened this issue May 17, 2019 · 3 comments
Closed

react-native-windows interop with WinUI 3.0 #2492

jesbis opened this issue May 17, 2019 · 3 comments
Assignees
@asklar
Labels
Deliverable Major item tracked for top-level planning in ADO must-have p1
Milestone
0.63

Comments

@jesbis
Copy link
Member

jesbis commented May 17, 2019

With the planned upcoming release of WinUI 3.0 which will be the next version of the native Windows UI platform, it seems worth considering:

  1. react-windows-native core using WinUI instead of the older version of Windows::UI::Xaml

  2. enabling using WinUI controls in native UI components/views
@jesbis jesbis added the vnext label May 17, 2019
@ghost ghost added the Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) label May 17, 2019
@kikisaints
Copy link
Contributor

kikisaints commented May 20, 2019 •
edited
Loading

An expansion on 2. would be to make sure that any Windows, separate npm components installed into a React Native project, use WinUI where it makes sense to.

For example if we make a react-native-windows-progressbar, it's using a WinUI progress bar as well - not only the components in react-native-windows.

@harinikmsft harinikmsft added this to the vNext Milestone 3 milestone May 20, 2019
@harinikmsft harinikmsft added must-have p1 and removed Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) labels May 22, 2019
@jesbis jesbis mentioned this issue May 22, 2019
Closed
@chrisglein chrisglein removed the vnext label Mar 18, 2020
@chrisglein chrisglein added the Deliverable Major item tracked for top-level planning in ADO label Apr 22, 2020
@chrisglein
Copy link
Member

WinUI3 alpha exists, enabling us to begin investigation into this. It's likely that there will be gaps and roadblocks, and that many of those won't be clear until we have an app targeting this. So it seems like we would potentially want to create a branch and separate nuget preview for this so we can solicit feedback. As that it may be floating in pre-release for awhile we may also need a mechanism for supporting both side by side (namespace macros?).

This was referenced Apr 25, 2020
Closed
Merged
asklar added a commit that referenced this issue May 5, 2020
@asklar
RNW on WinUI3! (#4766)
f467d8b 
Accrues towards #2492

Migrates RN code to straddle OS XAML and WinUI 3 (MUX/MUC)+WebView2
Creates a WinUI3 build config which is "build with WinUI3 in Debug". This is handled by:
specifying both WinUI 2.x and 3.0 Alpha in packages.config,
conditionally including one or the other props/targets based on a flag that is set (UseWinUI3)
In code the UseWinUI3 flag is translated into the USE_WINUI3 macro which dictates a number of things: XAML and Comp namespaces, as well as whether to use WebView or WebView2.
This build configuration is added to the PR CI.
Once we validate all our partners are ok with WinUI3 we can flip the switch and make this the default. In the meantime this allows us to validate the approach as well as make sure our code doesn't rot out of being WinUI-friendly.
@chrisglein chrisglein mentioned this issue May 8, 2020
Closed
@chrisglein
Copy link
Member

@asklar I think at this point we can close this issue, agree? As in we've graduated on to more specific issues.

@asklar asklar closed this as completed Jul 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@asklar asklar

Labels
Deliverable Major item tracked for top-level planning in ADO must-have p1
Projects
None yet
Milestone
0.63
Development

No branches or pull requests
5 participants
@kikisaints @jesbis @harinikmsft @asklar @chrisglein