Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove patches for fixes to prevent 4018, 4244 warnings #12300

Closed
jonthysell opened this issue Oct 26, 2023 · 1 comment
Closed

Remove patches for fixes to prevent 4018, 4244 warnings #12300

jonthysell opened this issue Oct 26, 2023 · 1 comment
Assignees
@TatianaKapos
Labels
Deforking enhancement Integration Follow-up PR Follow-up Issue created in response to PR Feedback (labeled so we can gather telemetry on follow-up) Upstream
Milestone
Backlog

Comments

@jonthysell
Copy link
Contributor

In order to pass the new BinSkim requirements for the 1ES template (see PR #12295) we had to remove some of the previously suppressed compiler warnings, specifically 4018 and 4244.

In order to build I had to patch the following files:

  • vnext\ReactCommon\TEMP_UntilReactCommonUpdate\react\renderer\core\ShadowNode.cpp
  • vnext\ReactCommon\TEMP_UntilReactCommonUpdate\react\renderer\core\RawPropsParser.cpp
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) label Oct 26, 2023
@jonthysell jonthysell added this to the 0.74 milestone Oct 30, 2023
@jonthysell jonthysell added Upstream PR Follow-up Issue created in response to PR Feedback (labeled so we can gather telemetry on follow-up) labels Oct 30, 2023
@jonthysell jonthysell removed the Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) label Oct 30, 2023
@TatianaKapos TatianaKapos mentioned this issue Oct 30, 2023
Closed
@TatianaKapos TatianaKapos modified the milestones: 0.74, Next Oct 30, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot added the Invalid Triage https://github.com/microsoft/react-native-windows/wiki/Triage-Process (label applied by bot) label Oct 31, 2023
facebook-github-bot pushed a commit to facebook/react-native that referenced this issue Nov 1, 2023
@TatianaKapos @facebook-github-bot
Fix windows 4018 and 4244 compiler warnings (#41254)
695a30d 
Summary:
Windows had to remove some previously suppressed compiler warnings and fork `ShadowNode.cpp` and `RawPropsParser.cpp` (See: microsoft/react-native-windows#12300) to fix them. This PR adds the right data types and static casts to get rid of the compiler warnings.

## Changelog:

[GENERAL] [FIXED] - Fix windows 4018 and 4244 compiler warnings

Pull Request resolved: #41254

Test Plan: tested in RNW Repository

Reviewed By: rshest

Differential Revision: D50820705

Pulled By: rozele

fbshipit-source-id: fa61f7ca428d31fc6be56c80215246ee2bdfc67c
@chrisglein chrisglein added enhancement Integration Follow-up and removed Invalid Triage https://github.com/microsoft/react-native-windows/wiki/Triage-Process (label applied by bot) labels Nov 7, 2023
@chrisglein chrisglein modified the milestones: Next, Backlog Nov 7, 2023
Othinn pushed a commit to Othinn/react-native that referenced this issue Jan 9, 2024
@TatianaKapos @Othinn
Fix windows 4018 and 4244 compiler warnings (facebook#41254)
ee2b3f9 
Summary:
Windows had to remove some previously suppressed compiler warnings and fork `ShadowNode.cpp` and `RawPropsParser.cpp` (See: microsoft/react-native-windows#12300) to fix them. This PR adds the right data types and static casts to get rid of the compiler warnings.

## Changelog:

[GENERAL] [FIXED] - Fix windows 4018 and 4244 compiler warnings

Pull Request resolved: facebook#41254

Test Plan: tested in RNW Repository

Reviewed By: rshest

Differential Revision: D50820705

Pulled By: rozele

fbshipit-source-id: fa61f7ca428d31fc6be56c80215246ee2bdfc67c
@marlenecota marlenecota mentioned this issue Feb 6, 2024
Merged
@TatianaKapos
Copy link
Contributor

closed via #12679

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TatianaKapos TatianaKapos

Labels
Deforking enhancement Integration Follow-up PR Follow-up Issue created in response to PR Feedback (labeled so we can gather telemetry on follow-up) Upstream
Projects
RNW New Architecture
Status: Done
Milestone
Backlog
Development

No branches or pull requests
3 participants
@jonthysell @chrisglein @TatianaKapos