Skip to content

Commit

Permalink
Fix escaping arguments for PowerShell tasks (#13918) ***NO_CI***
Browse files Browse the repository at this point in the history
## Description

Fixing error blocking PRs due to surprise ADO policy change:

```
Detected characters in arguments that may not be executed correctly by the shell. Please escape special characters using backtick (`). More information is available here: https://aka.ms/ado/75787
```

### Type of Change
_Erase all that don't apply._
- Bug fix (non-breaking change which fixes an issue)

### Why
Unblock pipelines.

### What
Fixed argument escaping.

## Screenshots
N/A

## Testing
N/A

## Changelog
Should this change be included in the release notes: _no_
  • Loading branch information
jonthysell committed Oct 3, 2024
1 parent 9948e1b commit d8894ea
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 10 deletions.
7 changes: 2 additions & 5 deletions .ado/jobs/playground.yml
Original file line number Diff line number Diff line change
Expand Up @@ -193,12 +193,9 @@ jobs:
New-Item -Path '$(Build.StagingDirectory)\DebugTestCrashDumps' -ItemType Directory
displayName: Set CrashDumpRootPath
- task: PowerShell@2
- powershell: |
& $(Build.SourcesDirectory)\.ado\scripts\RunProcDump.ps1 -ProcDumpArgs @("-mm", "-i", "$(CrashDumpRootPath)") -ProcDumpInstallPath "$(ProcDumpPath)" -Verbose
displayName: Setup ProcDump as AeDebug
inputs:
targetType: filePath # filePath | inline
filePath: $(Build.SourcesDirectory)\.ado\scripts\RunProcDump.ps1
arguments: "-ProcDumpArgs @('-mm', '-i', '$(CrashDumpRootPath)') -ProcDumpInstallPath '$(ProcDumpPath)' -Verbose"
# This step loose-file-deploys the UWP Playground app and uses it as an RNW host for a series
# of debug feature tests. In the future, these tests should be performed against a host app
Expand Down
8 changes: 3 additions & 5 deletions .ado/templates/prepare-build-env.yml
Original file line number Diff line number Diff line change
Expand Up @@ -56,9 +56,7 @@ steps:
Write-Host "##vso[task.setvariable variable=ProcDumpPath]$(Build.StagingDirectory)\Procdump"
displayName: Set ProcDumpPath
- task: PowerShell@2
- powershell: |
& $(Build.SourcesDirectory)\.ado\scripts\RunProcDump.ps1 -ProcDumpArgs @("-mm", "-i", "$(CrashDumpRootPath)") -ProcDumpInstallPath "$(ProcDumpPath)" -Verbose
displayName: Setup ProcDump as AeDebug
inputs:
targetType: filePath # filePath | inline
filePath: $(Build.SourcesDirectory)\.ado\scripts\RunProcDump.ps1
arguments: "-ProcDumpArgs @('-mm', '-i', '$(CrashDumpRootPath)') -ProcDumpInstallPath '$(ProcDumpPath)' -Verbose"

0 comments on commit d8894ea

Please sign in to comment.