Need dirty() to be virtual to override in special cases.

See, for example ReactShadowNode in the ReactAndroid code base, which overrides this virtual.
microsoft · Jan 5, 2016 · 3d7bc48 · 3d7bc48
1 parent 219bdae
commit 3d7bc48
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/src/csharp/Facebook.CSSLayout/CSSConstants.cs b/src/csharp/Facebook.CSSLayout/CSSConstants.cs
@@ -11,7 +11,7 @@ namespace Facebook.CSSLayout
 {
     public static class CSSConstants 
     {
-        public static readonly float Undefined = float.NaN;
+        public const float Undefined = float.NaN;
 
         public static bool IsUndefined(float value) 
         {

diff --git a/src/csharp/Facebook.CSSLayout/CSSNode.cs b/src/csharp/Facebook.CSSLayout/CSSNode.cs
@@ -179,7 +179,7 @@ public bool HasNewLayout
             get { return mLayoutState == LayoutState.HAS_NEW_LAYOUT; }
         }
 
-        internal protected void dirty()
+        internal protected virtual void dirty()
         {
             if (mLayoutState == LayoutState.DIRTY)
             {