Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(windows): always enable NuGet when building New Arch #2269

Merged
merged 1 commit into from
Oct 2, 2024
Merged

fix(windows): always enable NuGet when building New Arch #2269

merged 1 commit into from
Oct 2, 2024

Conversation

tido64
Copy link
Member

@tido64 tido64 commented Oct 2, 2024

Description

We can no longer build Windows + New Arch without NuGet. Not sure if it's a bug, but this will unblock early adopters.

Platforms affected

  • Android
  • iOS
  • macOS
  • visionOS
  • Windows

Test plan

npm run set-react-version 0.76
yarn remove react-native-macos --all
cd example
yarn install-windows-test-app --use-fabric
yarn windows

@tido64
fix(windows): always enable NuGet when building New Arch
5c56372 
We can no longer build Windows + New Arch without NuGet. Not sure if
it's a bug, but this will unblock early adopters.
@github-actions github-actions bot added the platform: Windows This affects Windows label Oct 2, 2024
@tido64 tido64 mentioned this pull request Oct 2, 2024
Closed
33 tasks
@tido64 tido64 merged commit 3bb405e into trunk Oct 2, 2024
27 checks passed
@tido64 tido64 deleted the tido/windows/new-arch-nuget branch October 2, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acoates-ms acoates-ms acoates-ms approved these changes

@JasonVMo JasonVMo Awaiting requested review from JasonVMo JasonVMo is a code owner

Assignees
No one assigned
Labels
platform: Windows This affects Windows
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tido64 @acoates-ms