Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Windows): Debug settings are not persisted across sessions #212

Merged
merged 2 commits into from
Oct 16, 2020

Conversation

tido64
Copy link
Member

@tido64 tido64 commented Sep 5, 2020

Normal With Access Keys
image image
image image

To Do

Test Plan

  1. Build and run Windows test app
  2. The debug menu should be disabled
    • Ctrl+Shift+D should open react-native-windows' developer menu
  3. Run git clean -dfqx to restore state
  4. Bump react-native to ^0.63 and react-native-windows to ^0.63.5 (see diff below)
  5. Build and run Windows test app
  6. The debug menu should be enabled
    • Ctrl+Shift+D should open it instead of react-native-windows' developer menu
    • The state of each item in the debug menu should be restored when the app is restarted
    • Toggle Inspector should always work, even after a JS reload
diff --git a/example/package.json b/example/package.json
index 5bde75f..2d7104d 100644
--- a/example/package.json
+++ b/example/package.json
@@ -25,10 +25,9 @@
   "devDependencies": {
     "@babel/core": "^7.0.0",
     "mkdirp": "^0.5.1",
-    "react": "16.11.0",
-    "react-native": "0.62.2",
-    "react-native-macos": "0.62.14",
+    "react": "16.13.1",
+    "react-native": "0.63.3",
     "react-native-test-app": "../",
-    "react-native-windows": "0.62.12"
+    "react-native-windows": "0.63.5"
   }
 }

@tido64 tido64 added the platform: Windows This affects Windows label Sep 5, 2020
@tido64 tido64 force-pushed the tido/rn-62 branch 2 times, most recently from e76d332 to 882187f Compare September 5, 2020 21:45
Base automatically changed from tido/rn-62 to master September 7, 2020 09:05
@tido64 tido64 force-pushed the tido/windows-debug-menu branch 7 times, most recently from 42a0cbf to 9e16367 Compare October 4, 2020 17:08
@tido64 tido64 force-pushed the tido/windows-debug-menu branch 2 times, most recently from 9da9a96 to a2364ac Compare October 8, 2020 11:54
@tido64 tido64 marked this pull request as ready for review October 12, 2020 16:56
@tido64 tido64 force-pushed the tido/windows-debug-menu branch 3 times, most recently from 45a8294 to 6558cff Compare October 13, 2020 00:31
@kelset kelset self-requested a review October 16, 2020 12:03
Copy link
Contributor

@kelset kelset left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, talked with Tommy about it and walked through the main code changes - so only one thing left to do:

@tido64
Copy link
Member Author

tido64 commented Oct 16, 2020

@kelset
thanks

@tido64 tido64 merged commit c943788 into master Oct 16, 2020
@tido64 tido64 deleted the tido/windows-debug-menu branch October 16, 2020 15:55
@tido64
Copy link
Member Author

tido64 commented Oct 16, 2020

🎉 This PR is included in version 0.2.12 🎉

The release is available on:

Your semantic-release bot 📦🚀

@tido64 tido64 mentioned this pull request Oct 17, 2021
34 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform: Windows This affects Windows released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants