Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ios): patch React-Fabric build failure #1755

Merged
merged 3 commits into from
Jan 4, 2024
Merged

Conversation

tido64
Copy link
Member

@tido64 tido64 commented Jan 4, 2024

Description

❌ /~/example/ios/Pods/Headers/Public/React-Fabric/react/renderer/core/RawPropsParser.h:50:24: no matching constructor for initialization of 'PropsParserContext'
    PropsParserContext parserContext{-1, contextContainer};
                       ^            ~~~~~~~~~~~~~~~~~~~~~~

Upstream fix: facebook/react-native#42138

Platforms affected

  • Android
  • iOS
  • macOS
  • Windows

Test plan

You will have to manually downgrade react-native-safe-area-context to 4.7.4 first, then run:

yarn
cd example
RCT_NEW_ARCH_ENABLED=1 pod install --project-directory=ios
yarn ios

# In a separate terminal
yarn start

@tido64 tido64 requested a review from kelset January 4, 2024 11:08
@tido64 tido64 mentioned this pull request Jan 4, 2024
8 tasks
@kelset
Copy link
Contributor

kelset commented Jan 4, 2024

Changes LGTM and tested locally and it works:
Screenshot 2024-01-04 at 12 33 43

@tido64 tido64 merged commit 63a8811 into trunk Jan 4, 2024
27 checks passed
@tido64 tido64 deleted the tido/patch-ios-new-arch branch January 4, 2024 12:45
@tido64 tido64 mentioned this pull request Jan 4, 2024
34 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants