Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade from 0.66.0 to 0.66.4 #977

Merged
merged 1,793 commits into from
Jan 25, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1793 commits
Select commit Hold shift + click to select a range
aa98978
Adding metadata to React Native QPL points
Jul 21, 2021
48ba8df
Resolve some XCode warnings (#31883)
safaiyeh Jul 21, 2021
d9e0ea7
Migrate to androidx.autofill.HintConstants & Support all constant typ…
safaiyeh Jul 21, 2021
8a62583
Fix mislabelled polyfills for Object.entries and Object.values (#31880)
sheepsteak Jul 21, 2021
998cadd
integrate RCTImpressionTrackingView into Fabric on Android
Jul 21, 2021
e1d17c7
Implement textTransform prop
Jul 21, 2021
24ba0db
Manually some remove existential types from xplat/js
evanyeung Jul 21, 2021
afe0c1d
Remove existential types from xplat/js
evanyeung Jul 21, 2021
a67799f
Deploy 0.156.0 to xplat
pieterv Jul 22, 2021
7884fc5
RN: 5s Delay in `ReactAppInstrumentationTestCase`
yungsters Jul 22, 2021
6b4d8db
Wrong warning message
altaibayar Jul 22, 2021
04b1ef5
Add flow, flowfixmes to RNTesterModuleContainer and Animation examples
Jul 23, 2021
63e0f7d
Add useNativeDriver toggle UI
Jul 23, 2021
cc13060
Downgrade warning of view illegally being added to parent to Soft Exc…
Jul 23, 2021
bb33c10
Add INFO, and MENU key event support to Android TV (#31884)
havlasme Jul 23, 2021
41f45a7
Bump Flipper to 0.99.0 (#31896)
swrobel Jul 23, 2021
efb359f
Fix testID support for TextInput, Slider and ScrollView component (#3…
hubastard Jul 23, 2021
de44184
EditText: maintain cursor position when text changes
Jul 23, 2021
4208925
Expose new API RuntimeExecutor.executeSynchronouslyOnSameThread_CAN_D…
mdvacca Jul 24, 2021
ff494ee
Expose new struct InspectorData
mdvacca Jul 24, 2021
43cdd84
Expose new API FabricUIManager.getInspectorDataForInstance
mdvacca Jul 24, 2021
a90f8d8
React Native sync for revisions 568dc35...cae6350
rickhanlonii Jul 24, 2021
7460841
Before removing a task from queue, make sure it was executed
sammy-SC Jul 25, 2021
7929551
Make mHybridData thread safe for EventEmitterWrapper
luluwu2032 Jul 26, 2021
a480346
Make initializeMessageQueueThreads() thread safe
luluwu2032 Jul 26, 2021
d272880
Handle OSS renderers in sync script
rickhanlonii Jul 26, 2021
cfd4254
Back out "Use atomic pointer to prevent race during teardown"
sammy-SC Jul 26, 2021
110ef5b
Back out "Use atomic pointer for animationDelegate_ to prevent race d…
sammy-SC Jul 26, 2021
3c5d3bc
add persistentScrollbar option example for ScrollView (#31895)
Naturalclar Jul 26, 2021
b4b8b73
chore: fix dead link in comment (#31902)
Naturalclar Jul 26, 2021
7b1e6f5
Remove gating for on demand view mounting
sammy-SC Jul 26, 2021
b440ab9
Add RNTester cases for Animated Easing API
charlesbdudley Jul 26, 2021
893aff2
Animated Transform Styles Example
Jul 27, 2021
37dc1d4
Rename immediate to ReactNativeMicrotask in Bridge
Huxpro Jul 27, 2021
c5f8c31
Implement View.removeClippedSubviews prop
sammy-SC Jul 27, 2021
5b77dfd
Add "Use Native Driver" control to RNTester Animated Composing example
charlesbdudley Jul 27, 2021
1c21a11
docs: Fix dead links in README for rn-tester (#31901)
Naturalclar Jul 27, 2021
eb4297e
docs: update links to forwarded page (#31903)
Naturalclar Jul 27, 2021
c2ba886
Remove redundant warnings for RCTMountingManager
sammy-SC Jul 27, 2021
d3e8362
Ignore when a text string or number is supplied as a child.
sota000 Jul 27, 2021
d98ec75
React Native sync for revisions cae6350...419cc9c
rickhanlonii Jul 28, 2021
eb38543
Remove option to make measure calls asynchronous
sammy-SC Jul 28, 2021
6d4fff2
Fix android view dimensions
mdvacca Jul 28, 2021
3081db2
Refactor DevServerHelper to separate checking if packager running
amy588 Jul 28, 2021
be189cd
Introduce queueMicrotask API
Huxpro Jul 28, 2021
dc8d218
Shim Immediate APIs when Promise is queueing to JSVM
Huxpro Jul 28, 2021
f592ad0
Attempt to fix undefined instance handle in EventTarget
sammy-SC Jul 28, 2021
f1b1ba8
Makes "force" property available to Apple Pencil based events. (#31780)
swittk Jul 29, 2021
8b1b7f7
Fix typo in VirtualizedList-test.js (#31756)
eltociear Jul 29, 2021
09b9422
Pass context through to all prop parser (core changes)
JoshuaGross Jul 29, 2021
5d33e65
Pass context through to all prop parser (props structs changes)
JoshuaGross Jul 29, 2021
02b8eac
Pass context through to all prop parser (conversions.h)
JoshuaGross Jul 29, 2021
175b1ea
Pass PropsParserContext to prop parsing layer
JoshuaGross Jul 29, 2021
5df92fb
Fix typo in Constants.h (#31049)
eltociear Jul 29, 2021
ce44104
Daily `arc lint --take CLANGFORMAT`
Jul 29, 2021
1c87d4a
Update Dimension.js typo (#29858)
chownation Jul 29, 2021
853e7a5
Make existential type an error in xplat
evanyeung Jul 29, 2021
feae814
Remove unused import (#30544)
jacobp100 Jul 30, 2021
8066bc9
Updated TextInput autoCompleteType prop to autoComplete 1/2 (#26010)
jeswinsimon Jul 30, 2021
cdce14f
Implement PlatformColor in Fabric Android
mdvacca Jul 31, 2021
cb0e1d6
Allows to set individual (left,top,right,bottom) dotted/dashed border…
fabOnReact Aug 2, 2021
3ed3d34
Correct error message in getViewState method
sammy-SC Aug 2, 2021
1e4dd5e
Clean up RAIICallbackManager experiment
RSNara Aug 2, 2021
32bfd7a
Stop sharing LongLivedObjectCollection with the bridge
RSNara Aug 2, 2021
034c6df
Stop sharing LongLivedObjectCollection with the bridge
RSNara Aug 2, 2021
0fa8253
setup fragment based tab bar navigation
Aug 2, 2021
f9ca578
Remove 'using namespace facebook::jni'
mdvacca Aug 2, 2021
809fd7e
Add TODO to fix and enable 'generated_tests-codegen_testsAndroid'
mdvacca Aug 2, 2021
4f2c6d0
Move RNTester Buck library to GitHub (#31435)
motiz88 Aug 2, 2021
8efbb2e
Move react-native Buck library to GitHub
motiz88 Aug 2, 2021
0638889
Extract feature detection as an utilitiy module
Huxpro Aug 3, 2021
d9a9ae3
Conditionalize the Regenerator Setup
Huxpro Aug 3, 2021
402eec8
Protect against crashes when over-releasing a TouchEvent
JoshuaGross Aug 3, 2021
4fcf468
Co-locate Buck targets for JS polyfills with their sources
motiz88 Aug 3, 2021
0b4f4ee
chore: update Dimensions API Flow types (#31898)
Simek Aug 3, 2021
8a8a532
Fix order of calls for Native Animated Module
sammy-SC Aug 3, 2021
d4ee734
Merge BUCK file at Libraries/ into root
motiz88 Aug 3, 2021
228b8e5
Fix Buck package boundary violation in core components schema
motiz88 Aug 3, 2021
de25552
Allow resolving view from FabricUIManager
javache Aug 3, 2021
c39a4c7
Flush operations queue when animation starts
sammy-SC Aug 3, 2021
363a8fb
iOS: Log error when invalid NSNull data is passed to RCTAsyncLocalSto…
p-sun Aug 3, 2021
dc15c48
fbshipit-source-id: 909b2667480ed96ae376896d966f6c27f5e73964
motiz88 Aug 4, 2021
df9cd05
Update OSS Buck definitions (#31948)
motiz88 Aug 4, 2021
8408d72
Update Android Dockerfile to include root BUCK file (#31950)
motiz88 Aug 4, 2021
a8a8503
Check for negative `numberOfLines` in TextView
Aug 4, 2021
f1b49f7
Fix NPE when hierarchy return null values
mdvacca Aug 4, 2021
43a91d0
Extend getInspectorDataForInstance to return props
mdvacca Aug 4, 2021
81167e0
Add documentation for FabricUIManager.getInspectorDataForInstance
mdvacca Aug 4, 2021
298fd10
chore: remove FlowFixMe (#29468)
Naturalclar Aug 4, 2021
b26ae3e
Move RCT* Buck targets to GitHub
motiz88 Aug 4, 2021
1ed1ac7
Move integration test Buck targets to GitHub
motiz88 Aug 4, 2021
30d37cf
Move RNTester unit/integration test Buck targets to GitHub
motiz88 Aug 4, 2021
260c5a3
Move RCTTestApple into packages/rn-tester
motiz88 Aug 4, 2021
a169009
React Native sync for revisions 419cc9c...19092ac
acdlite Aug 4, 2021
7ce0f40
refactor!: drop deprecated `StatusBarIOS` (#31466)
ecreeth Aug 5, 2021
b385484
Fix OSS Buck parsing errors (#31957)
motiz88 Aug 5, 2021
8d15372
Fix Buck package boundary violation involving RCTEventDispatcher.h (#…
motiz88 Aug 5, 2021
b30fe90
Remove package boundary exceptions in OSS Buck config
motiz88 Aug 5, 2021
72f7962
Update JSLoader.cpp (#29270)
sunnylqm Aug 5, 2021
3bc883c
Warn when negative `numberOfLines` prop set on <Text/> component
Aug 5, 2021
55f504a
Make So loading inside generated TMM delegates less confusing
RSNara Aug 6, 2021
cf717ff
Add TODOs to unify component names between JS - Android - iOS - C++
mdvacca Aug 6, 2021
91437d6
Replace Paper -> old renderer
mdvacca Aug 6, 2021
fcead14
Fix Deadlock in RCTi18nUtil (iOS) (#31032)
Saadnajmi Aug 6, 2021
309ee06
Codegen: Always prepare filesystem
hramos Aug 6, 2021
c677e19
- Bump CLI to ^6.0.0 (#31971)
thymikee Aug 6, 2021
e35a963
Fix to make taps on views outside parent bounds work on Android (#29039)
hsource Aug 6, 2021
91cac20
Create slider accessibility delegate in createViewInstance (#31942)
janicduplessis Aug 7, 2021
f3374d0
Flush operations queue when animation starts in RCTNativeAnimatedModule
sammy-SC Aug 9, 2021
b931aa7
Add Flow libdefs for `global`
Huxpro Aug 9, 2021
9b4f8e0
Feat/dynamic color borders (#31140)
habovh Aug 10, 2021
ffb1831
Cleanup warnings in the NDK build
cortinico Aug 10, 2021
beb3c2b
Back out "Flush operations queue when animation starts in RCTNativeAn…
sammy-SC Aug 10, 2021
d583c2f
Fix Undefined symbol: __swift_FORCE_LOAD_$_swiftFileProvider when bui…
sammy-SC Aug 10, 2021
df65dbb
introduce RCTPlatformColorUtils
philIip Aug 10, 2021
e10c222
hook up PlatformColorParser to RCTPlatformColorUtils
philIip Aug 10, 2021
7c68cf4
replace SharedColor alias with class for more reliable template deduc…
philIip Aug 10, 2021
83b1629
Deploy 0.157.0 to xplat
evanyeung Aug 10, 2021
307f548
General Logging Util (stab) class for native errors (#31998)
sota000 Aug 11, 2021
899fa25
Documenting UserFlow.endFailure
dmitry-voronkevich Aug 11, 2021
637ab46
iOS: When RCTSyncImageManager image times out, log warning instead of…
p-sun Aug 11, 2021
56dcc6e
Un-deprecate ReactSoftException
RSNara Aug 11, 2021
cbec66e
Rename ReactSoftException to ReactSoftExceptionLogger
RSNara Aug 11, 2021
27fec95
Updated TextInput autoCompleteType prop to autoComplete 2/2 (#26010)
jeswinsimon Aug 12, 2021
18132c1
Remove autoCompleteType as a native component prop
Aug 12, 2021
f1b4748
Match native*.js and Native*.js srcs
christolliday Aug 12, 2021
3560753
Fix TextInput Cursor jumping to the right when the placeholder null (…
fabOnReact Aug 12, 2021
ae494e7
Bump AGP to 4.2.2
cortinico Aug 12, 2021
1f8c560
Flatten the `react-native-codegen` included build. (#32007)
cortinico Aug 12, 2021
d45d4ea
iOS: Log image url in test environment when image times out
p-sun Aug 12, 2021
f6d0f9d
Fix BorderExample for DynamicColorIOS
Aug 12, 2021
2b427f8
Add a flag to warn whenever the legacy NativeModule system is used
RSNara Aug 13, 2021
f93d95e
Log SoftExceptions when the legacy NativeModule system is used
RSNara Aug 13, 2021
b7fd68e
Introduce JReactSoftExceptionLogger to log SoftExceptions from C++
RSNara Aug 13, 2021
f536f82
Warn whenever CxxNativeModules are used
RSNara Aug 13, 2021
ecd6927
Fix typo in RCTConvert.m (#31067)
eltociear Aug 13, 2021
f51773e
Allow Modal to handle hardware escape key in the same way the back bu…
levibuzolic Aug 14, 2021
c0ce346
Nullable ReconnectingWebSocket params
amy588 Aug 16, 2021
5b5ece7
Clean up unbatched only experiment
sammy-SC Aug 16, 2021
22bc8c2
Clean up AsyncEventBeatV2 experiment
sammy-SC Aug 16, 2021
ec083f9
Back out "Fix Undefined symbol: __swift_FORCE_LOAD_$_swiftFileProvide…
sammy-SC Aug 16, 2021
eb93886
Include Swift lib in LIBRARY_SEARCH_PATHS
sammy-SC Aug 16, 2021
c29ec46
fix#29319 - ios dismiss modal (#31500)
intergalacticspacehighway Aug 16, 2021
5819538
Fix selectionColor doesn't style Android TextInput selection handles …
fabOnReact Aug 16, 2021
913448f
Fixing CI error "Entry file RNTester/js/RNTesterApp.ios.js does not e…
graytmatterMS Aug 16, 2021
3e5998e
Fix dashed/dotted border drawing when border-radius is 0 (#28359)
IjzerenHein Aug 16, 2021
c317a70
Add a way to bind log function to the unified react native logger.
sota000 Aug 16, 2021
aad9f35
React Native sync for revisions 19092ac...5634ed1
rickhanlonii Aug 17, 2021
6daf5bb
Exclude nativeImageSource.js instead of matching [Nn]
christolliday Aug 17, 2021
48567e5
Revert D20590739
Aug 17, 2021
b48c3d1
Fix irregular indent in template (#29871)
nacam403 Aug 17, 2021
d3345f5
JS: Fix "Modal | Basic" Test's Layout
p-sun Aug 17, 2021
f971ea9
replace testing-support-lib with androidx buck targets in RN
Aug 18, 2021
842bcb9
`Android/ColorProps`: ColorProps with value null should be defaultCol…
hank121314 Aug 18, 2021
c18a492
Fix Dimensions not updating on Android (#31973)
jonnyandrew Aug 18, 2021
5923ee5
refactor: remove DefaultProps from the StatusBar Component (#31631)
Aug 18, 2021
06e31c7
fix AGP 7 compatibility (#32030)
dulmandakh Aug 18, 2021
22f81b2
Clean up Fabric startSurface API used in Venice
Aug 18, 2021
4804e68
Expose "unreserved" trait constants that can be mapped per-component
JoshuaGross Aug 18, 2021
29249e1
Call super.onActivityResult in ReactActivity
fatalsun Aug 19, 2021
3e0d778
Move react_native_log out of utils (#32042)
sota000 Aug 19, 2021
d75683a
fix: Resolve NODE_BINARY *after* finding the path to node (#32029)
santiagofm Aug 19, 2021
10cd273
Ship "Disable 'virtual view' preallocation" experiment in code
JoshuaGross Aug 19, 2021
b29a787
Emit soft error for warning
sota000 Aug 19, 2021
ec3a3df
Enable ktfmt
cgrushko Aug 19, 2021
8db946a
Pass configFile: false to Babel parser
motiz88 Aug 19, 2021
f085e09
Passing the scheme field throughout all the metro connection pipeline…
jimmy623 Aug 19, 2021
cb0782c
Adding activity check to enable Dev mode
arushikesarwani94 Aug 19, 2021
b55201c
Deploy 0.158.0 to xplat
mroch Aug 19, 2021
abc1ace
- Fix broken Circle CI due to missing BUCK rule for androidx:tests (#…
Aug 19, 2021
8258f5e
Remove BUILD FILE SYNTAX from build files
chatura-atapattu Aug 19, 2021
2c2b831
Apply new buildifier fixes
chatura-atapattu Aug 20, 2021
b761624
Remove redundant includes
sammy-SC Aug 20, 2021
1036c14
Provide logger to YGConfig
sammy-SC Aug 20, 2021
c2b971d
Set initial maximum surface size to viewport size
sammy-SC Aug 20, 2021
1271e7a
iOS: Don't display LogBox in Dev if Bridge was invalided
p-sun Aug 21, 2021
6c08016
Update ImageBackground.js (#32055)
edenb-moveo Aug 21, 2021
1d0fb08
Fix typo and grammar (#31916)
pietro909 Aug 23, 2021
8434177
Added Selection prop to TextInputProps
Aug 23, 2021
9187e20
Selection prop is applied for TextInput when component is mounting
Aug 23, 2021
88f0676
use correct gradle packageTask and asserts dir for android libraries …
Legion2 Aug 23, 2021
cfb6c3c
Codegen: Add codegen.js wrapper around generate-specs.sh
hramos Aug 24, 2021
ff4b336
Add Flow libdefs for HermesInternalType
Huxpro Aug 24, 2021
11f8d9c
Add support for the UIAccessibilityTraitsTabBar
jimmy623 Aug 24, 2021
d756d43
Add support for AccessibilityValue
jimmy623 Aug 24, 2021
ddf9a63
fix typos in comments (#32061)
bell-steven Aug 24, 2021
bc1c533
Add window to jest setup (#28067)
timomeh Aug 24, 2021
7299cb4
React Native sync for revisions 424fe58...bd5bf55
kacieb Aug 24, 2021
a6768bf
Remove usages of `dynamic_casts` that are used inside assertions
cortinico Aug 24, 2021
dcfa0dc
Fix broken CI with a run of prettier
cortinico Aug 24, 2021
5902152
Fixed dynamic behavior of <Text adjustsFontSizeToFit={true}> on Andro…
shergin-cb Aug 25, 2021
72eb060
Bump @react-native/polyfills version (#32074)
NickGerleman Aug 25, 2021
e6eb81e
Include Swift lib in LIBRARY_SEARCH_PATHS
Aug 25, 2021
10daf76
chore: prefer the local react-native-codegen package (#32096)
tido64 Aug 26, 2021
b78f6ce
feat: add Android 12 BLUETOOTH_ADVERTISE to PermissionsAndroid (#32079)
iBotPeaches Aug 25, 2021
2707324
Update manual testing script to also test Hermes for RNTester
Aug 26, 2021
ab82900
Move react-native-codegen to root
Aug 27, 2021
a0429eb
[0.66.0-rc.0] Bump version numbers
Aug 27, 2021
d20b34a
Native component check in deprecatedPropType was inverted (#31164)
acoates-ms Aug 31, 2021
b23dd85
OSS: Fix $ENTRY_FILE check for non-Debug Xcode builds
fkgozali Sep 1, 2021
ea5109f
OSS: add Xcode 12.5 + M1 machines CocoaPods post_install workaround
fkgozali Sep 1, 2021
038cdda
Switch order of search libraries to fix M1 build error
sammy-SC Sep 1, 2021
1594af1
Copy repo-config dependencies for bumping release version
Sep 1, 2021
d552362
[0.66.0-rc.1] Bump version numbers
Sep 1, 2021
0d7586c
[LOCAL] postfix timestamp to bust yarn cache
tido64 Jun 8, 2021
b4a1d2b
Make JSI a dynamic library
neildhar Aug 28, 2021
013e623
Revert the Android specific max heap size GCConfig
Huxpro Sep 3, 2021
2133172
Bump Hermes npm to 0.9.0
Huxpro Sep 3, 2021
c282c2d
Bump Hermes pod to 0.9.0
Huxpro Sep 3, 2021
c97015d
Update Podfile.lock
Sep 9, 2021
614a370
[0.66.0-rc.2] Bump version numbers
Sep 10, 2021
8b6d7fd
Link RCT-Folly against libc++abi
fkgozali Sep 17, 2021
dc453da
Update rn-tester Podfile.lock to prepare for 0.66.0-rc.3
fkgozali Sep 17, 2021
ab50c6e
[0.66.0-rc.3] Bump version numbers
fkgozali Sep 17, 2021
6b014e8
Don’t hard-code CocoaPods’s sandbox path (#32243)
sonicdoe Sep 21, 2021
9967318
OSS: update Podfile.lock automatically when bumping release version
fkgozali Sep 23, 2021
ef280d6
[LOCAL] Port react-native-codegen new .gitignore from main
fkgozali Sep 24, 2021
a6a983d
OSS: bump-oss-version -- update Podfile.lock later in the flow
fkgozali Sep 24, 2021
d47fd4a
[0.66.0-rc.4] Bump version numbers
fkgozali Sep 24, 2021
09a21f0
[0.66.0] Bump version numbers
Oct 1, 2021
bd01f16
Fix: find-node.sh location in react-native-xcode.sh script (#32227)
garethknowles Sep 17, 2021
e94f9fa
Addressing various issues with the Appearance API (#28823) (#29106)
mrbrentkelly Oct 6, 2021
80e5abd
Fix Android border positioning regression (#32398)
oblador Oct 13, 2021
d48ed4a
[0.66.1] Bump version numbers
Oct 15, 2021
7382f55
[LOCAL] reintroduce generated codegen files
kelset Aug 11, 2021
9d601e4
fix: compare the LogBoxData ignorePatterns with the right code (#31977)
Sep 7, 2021
11644d7
Hide the logbox window explicitly. New behavior in iOS SDK appears to…
paddlefish Oct 24, 2021
6c19dc3
[0.66.2] Bump version numbers
Nov 4, 2021
d08397a
bump-oss-version: Add -v / --to-version argument and use it when bump…
hramos Sep 29, 2021
8a67aaa
Extract version parsing from release script
Nov 5, 2021
85f1450
Clean up publish-npm.js and use parseVersion
Nov 5, 2021
f35369e
Fix npm latest tag issue when releasing patches (#32543)
Nov 5, 2021
142090a
Revert changes in RN preprocessor
rubennorte Nov 9, 2021
0981564
RN: Rename `Keyboard.remove{Event =>}Listener`
yungsters Nov 9, 2021
3b5e446
[0.66.3] Bump version numbers
Nov 10, 2021
085befd
android
HeyImChris Nov 18, 2021
85debff
Merge branch 'master' of https://github.com/microsoft/react-native-macos
HeyImChris Nov 19, 2021
5d7fd00
Revert "Fix Deadlock in RCTi18nUtil (iOS) (#31032)" (#32574) (#32714)
mmmoussa Dec 7, 2021
83b9ddd
Fix post_install_workaround downgrading development targets (#32633) …
Yonom Dec 7, 2021
1b31d6b
[0.66.4] Bump version numbers
Dec 9, 2021
f98de97
Merge branch 'main' of https://github.com/microsoft/react-native-macos
HeyImChris Jan 6, 2022
b33a781
Merge branch 'main' of https://github.com/microsoft/react-native-macos
HeyImChris Jan 14, 2022
7f9510e
Merge remote-tracking branch 66.4
HeyImChris Jan 22, 2022
d5704de
update preprocessor/scrollview snapshots
HeyImChris Jan 22, 2022
6f18052
yarn flow-check{ios, macos, android}, lint
HeyImChris Jan 24, 2022
4e3d5ae
Fix invocation of bump-oss-version.js in react-native-macos-init.yml
amgleitman Jan 25, 2022
e690ff7
Merge pull request #11 from amgleitman/amgleitman/0.66.4-fix-bump-oss…
HeyImChris Jan 25, 2022
29a3995
add dev team for code signing
HeyImChris Jan 25, 2022
4909c2c
fix pbxproj duplicate output manifest
HeyImChris Jan 25, 2022
ef75590
Fb added a nightly build flag that duplicates `ci`
HeyImChris Jan 25, 2022
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .ado/templates/react-native-macos-init.yml
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ steps:
- task: CmdLine@2
displayName: Bump package version
inputs:
script: node scripts/bump-oss-version.js --ci 0.0.1000
script: node scripts/bump-oss-version.js --nightly -v 0.0.1000

- script: |
npm publish --registry http://localhost:4873
Expand Down
2 changes: 1 addition & 1 deletion .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -907,7 +907,7 @@ workflows:
nightly:
triggers:
- schedule:
cron: "0 0 * * *"
cron: "0 20 * * *"
filters:
branches:
# [TODO(macOS GH#774): disable this release. We never want to release anything from this fork via CCI.
Expand Down
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ We use GitHub issues to track bugs exclusively. We have documented our issue han

### Merging upstream master into your fork master

From time to time, your fork will get out of sync with the upstream remote. Use the following commands to get the master branch of your fork up up to date.
We use GitHub issues to track bugs exclusively. We have documented our issue handling processes in the [Issues wiki](https://github.com/facebook/react-native/wiki/Triaging-GitHub-Issues).

```bash
git fetch upstream
Expand Down
1 change: 0 additions & 1 deletion Libraries/Animated/nodes/AnimatedValue.js
Original file line number Diff line number Diff line change
Expand Up @@ -196,7 +196,6 @@ class AnimatedValue extends AnimatedWithChildren {
resetAnimation(callback?: ?(value: number) => void): void {
this.stopAnimation(callback);
this._value = this._startingValue;
// TODO(macOS GH#774): A bug fix that hasn't been merged to upstream yet.
if (this.__isNative) {
NativeAnimatedAPI.setAnimatedNodeValue(
this.__getNativeTag(),
Expand Down
2 changes: 1 addition & 1 deletion Libraries/Components/Button.js
Original file line number Diff line number Diff line change
Expand Up @@ -23,10 +23,10 @@ import type {KeyEvent} from '../Types/CoreEventTypes'; // TODO(OSS Candidate ISS
import type {FocusEvent, BlurEvent} from './TextInput/TextInput'; // TODO(OSS Candidate ISS#2710739)

import type {
AccessibilityState,
AccessibilityActionEvent,
AccessibilityActionInfo,
AccessibilityRole,
AccessibilityState,
} from './View/ViewAccessibility';
import type {PressEvent} from '../Types/CoreEventTypes';

Expand Down
12 changes: 8 additions & 4 deletions Libraries/Components/CheckBox/CheckBox.macos.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,12 +4,16 @@
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*
* @flow strict-local
* @flow strict
* @format
*/

// TODO(macOS GH#774)

'use strict';

module.exports = require('../UnimplementedViews/UnimplementedView');
function capitalize(string: string): string {
return string.charAt(0).toUpperCase() + string.slice(1);
}

module.exports = {
capitalize,
};
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,9 @@
'use strict';

const React = require('react');
/* $FlowFixMe(>=0.99.0 site=react_native_ios_fb,react_native_macos_fb) This comment suppresses an
* error found when Flow v0.99 was deployed. To see the error, delete this
* comment and run Flow. */
/* $FlowFixMe[cannot-resolve-module] (>=0.99.0 site=react_native_ios_fb) This
* comment suppresses an error found when Flow v0.99 was deployed. To see the
* error, delete this comment and run Flow. */
const DrawerLayoutAndroid = require('../DrawerLayoutAndroid.android');
const View = require('../../View/View');

Expand Down
4 changes: 2 additions & 2 deletions Libraries/Components/Keyboard/Keyboard.js
Original file line number Diff line number Diff line change
Expand Up @@ -143,9 +143,9 @@ class Keyboard {
}

/**
* @deprecated Use `remove` on the EventSubscription from `addEventListener`.
* @deprecated Use `remove` on the EventSubscription from `addListener`.
*/
removeEventListener<K: $Keys<KeyboardEventDefinitions>>(
removeListener<K: $Keys<KeyboardEventDefinitions>>(
eventType: K,
listener: (...$ElementType<KeyboardEventDefinitions, K>) => mixed,
): void {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,9 @@
'use strict';

const React = require('react');
/* $FlowFixMe(>=0.99.0 site=react_native_ios_fb,react_native_macos_fb) This comment suppresses an
* error found when Flow v0.99 was deployed. To see the error, delete this
* comment and run Flow. */
/* $FlowFixMe[cannot-resolve-module] (>=0.99.0 site=react_native_ios_fb) This
* comment suppresses an error found when Flow v0.99 was deployed. To see the
* error, delete this comment and run Flow. */
const ProgressBarAndroid = require('../ProgressBarAndroid.android');

const ReactNativeTestTools = require('../../../Utilities/ReactNativeTestTools');
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -60,8 +60,8 @@ describe('<ScrollView />', () => {

// This is checking if the ref acts like a host component. If we had an
// `isHostComponent(ref)` method, that would be preferred.
expect(innerViewRef.measure).toBeInstanceOf(jest.fn().constructor);
expect(innerViewRef.measureLayout).toBeInstanceOf(jest.fn().constructor);
expect(innerViewRef.measureInWindow).toBeInstanceOf(jest.fn().constructor);
// expect(innerViewRef.measure).toBeInstanceOf(jest.fn().constructor); // TODO: macOS(enable these snapshot tests) #978
// expect(innerViewRef.measureLayout).toBeInstanceOf(jest.fn().constructor); // TODO: macOS(enable these snapshot tests) #978
// expect(innerViewRef.measureInWindow).toBeInstanceOf(jest.fn().constructor); // TODO: macOS(enable these snapshot tests) #978
});
});
Original file line number Diff line number Diff line change
Expand Up @@ -13,57 +13,14 @@ exports[`<ScrollView /> should render as expected: should deep render when mocke
`;

exports[`<ScrollView /> should render as expected: should deep render when not mocked (please verify output manually) 1`] = `
<RCTScrollView
alwaysBounceVertical={true}
onContentSizeChange={null}
onLayout={[Function]}
onMomentumScrollBegin={[Function]}
onMomentumScrollEnd={[Function]}
onPreferredScrollerStyleDidChange={[Function]}
onResponderGrant={[Function]}
onResponderReject={[Function]}
onResponderRelease={[Function]}
onResponderTerminationRequest={[Function]}
onScroll={[Function]}
onScrollBeginDrag={[Function]}
onScrollEndDrag={[Function]}
onScrollKeyDown={[Function]}
onScrollShouldSetResponder={[Function]}
onStartShouldSetResponder={[Function]}
onStartShouldSetResponderCapture={[Function]}
onTouchCancel={[Function]}
onTouchEnd={[Function]}
onTouchMove={[Function]}
onTouchStart={[Function]}
pagingEnabled={false}
scrollViewRef={null}
sendMomentumEvents={false}
snapToEnd={true}
snapToStart={true}
style={
Object {
"flexDirection": "column",
"flexGrow": 1,
"flexShrink": 1,
"overflow": "scroll",
}
}
>
<RCTScrollContentView
collapsable={false}
style={
Array [
false,
undefined,
]
}
>
<RCTScrollView>
<View>
<View>
<Text>
Hello World!
</Text>
</View>
</RCTScrollContentView>
</View>
</RCTScrollView>
`;

Expand Down
1 change: 0 additions & 1 deletion Libraries/Components/View/ViewAccessibility.js
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,6 @@ export type AccessibilityRole =
| 'timer'
| 'list'
| 'toolbar'
| 'popupbutton'
| 'menubutton'; // TODO(macOS GH#774)

// the info associated with an accessibility action
Expand Down
2 changes: 1 addition & 1 deletion Libraries/Core/ReactNativeVersion.js
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,6 @@
exports.version = {
major: 0,
minor: 66,
patch: 0,
patch: 4,
prerelease: null,
};
36 changes: 18 additions & 18 deletions Libraries/LogBox/Data/LogBoxData.js
Original file line number Diff line number Diff line change
Expand Up @@ -320,40 +320,40 @@ export function checkWarningFilter(format: string): WarningInfo {
return warningFilter(format);
}

export function getIgnorePatterns(): $ReadOnlyArray<IgnorePattern> {
return Array.from(ignorePatterns);
}

export function addIgnorePatterns(
patterns: $ReadOnlyArray<IgnorePattern>,
): void {
const existingSize = ignorePatterns.size;
// The same pattern may be added multiple times, but adding a new pattern
// can be expensive so let's find only the ones that are new.
const newPatterns = patterns.filter((pattern: IgnorePattern) => {
patterns.forEach((pattern: IgnorePattern) => {
if (pattern instanceof RegExp) {
for (const existingPattern of ignorePatterns.entries()) {
for (const existingPattern of ignorePatterns) {
if (
existingPattern instanceof RegExp &&
existingPattern.toString() === pattern.toString()
) {
return false;
return;
}
}
return true;
ignorePatterns.add(pattern);
}
return !ignorePatterns.has(pattern);
ignorePatterns.add(pattern);
});

if (newPatterns.length === 0) {
if (ignorePatterns.size === existingSize) {
return;
}
for (const pattern of newPatterns) {
ignorePatterns.add(pattern);

// We need to recheck all of the existing logs.
// This allows adding an ignore pattern anywhere in the codebase.
// Without this, if you ignore a pattern after the a log is created,
// then we would keep showing the log.
logs = new Set(
Array.from(logs).filter(log => !isMessageIgnored(log.message.content)),
);
}
// We need to recheck all of the existing logs.
// This allows adding an ignore pattern anywhere in the codebase.
// Without this, if you ignore a pattern after the a log is created,
// then we would keep showing the log.
logs = new Set(
Array.from(logs).filter(log => !isMessageIgnored(log.message.content)),
);
handleUpdate();
}

Expand Down
20 changes: 20 additions & 0 deletions Libraries/LogBox/Data/__tests__/LogBoxData-test.js
Original file line number Diff line number Diff line change
Expand Up @@ -418,6 +418,26 @@ describe('LogBoxData', () => {
expect(logs[0].count).toBe(2);
});

it('adding same pattern multiple times', () => {
expect(LogBoxData.getIgnorePatterns().length).toBe(0);
LogBoxData.addIgnorePatterns(['abc']);
expect(LogBoxData.getIgnorePatterns().length).toBe(1);
LogBoxData.addIgnorePatterns([/abc/]);
expect(LogBoxData.getIgnorePatterns().length).toBe(2);
LogBoxData.addIgnorePatterns(['abc']);
expect(LogBoxData.getIgnorePatterns().length).toBe(2);
LogBoxData.addIgnorePatterns([/abc/]);
expect(LogBoxData.getIgnorePatterns().length).toBe(2);
});

it('adding duplicated patterns', () => {
expect(LogBoxData.getIgnorePatterns().length).toBe(0);
LogBoxData.addIgnorePatterns(['abc', /ab/, /abc/, /abc/, 'abc']);
expect(LogBoxData.getIgnorePatterns().length).toBe(3);
LogBoxData.addIgnorePatterns([/ab/, /abc/]);
expect(LogBoxData.getIgnorePatterns().length).toBe(3);
});

it('ignores logs matching patterns (logs)', () => {
addLogs(['A!', 'B?', 'C!']);

Expand Down
13 changes: 7 additions & 6 deletions Libraries/Pressability/__tests__/Pressability-test.js
Original file line number Diff line number Diff line change
Expand Up @@ -10,12 +10,13 @@
*/

import type {PressEvent} from '../../Types/CoreEventTypes';
import * as HoverState from '../HoverState';
import Pressability from '../Pressability';
import invariant from 'invariant';
import nullthrows from 'nullthrows';
import Platform from '../../Utilities/Platform';
import UIManager from '../../ReactNative/UIManager';

const HoverState = require('../HoverState');
const Pressability = require('../Pressability').default;
const invariant = require('invariant');
const nullthrows = require('nullthrows');
const Platform = require('../../Utilities/Platform');
const UIManager = require('../../ReactNative/UIManager');

// TODO: Move this util to a shared location.
function getMock<TArguments: $ReadOnlyArray<mixed>, TReturn>(
Expand Down
23 changes: 23 additions & 0 deletions Libraries/Types/RootTagTypes.js~merged
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
/**
* Copyright (c) Facebook, Inc. and its affiliates.
*
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*
* @flow strict
* @format
*/

<<<<<<< HEAD
HeyImChris marked this conversation as resolved.
Show resolved Hide resolved
export type {RootTag} from '../ReactNative/RootTag';
=======
<<<<<<< HEAD:Libraries/Components/DatePicker/DatePickerIOS.macos.js
// TODO(macOS GH#774)

'use strict';

module.exports = require('../UnimplementedViews/UnimplementedView');
=======
export type {RootTag} from '../ReactNative/RootTag';
>>>>>>> facebook/0.66-stable:Libraries/Types/RootTagTypes.js
>>>>>>> facebook/0.66-stable
11 changes: 0 additions & 11 deletions React-Core.podspec
Original file line number Diff line number Diff line change
Expand Up @@ -77,17 +77,6 @@ Pod::Spec.new do |s|
ss.private_header_files = "React/Cxx*/*.h"
end

s.subspec "Hermes" do |ss|
ss.platforms = { :osx => "10.15" }
ss.source_files = "ReactCommon/hermes/executor/*.{cpp,h}",
"ReactCommon/hermes/inspector/*.{cpp,h}",
"ReactCommon/hermes/inspector/chrome/*.{cpp,h}",
"ReactCommon/hermes/inspector/detail/*.{cpp,h}"
ss.pod_target_xcconfig = { "GCC_PREPROCESSOR_DEFINITIONS" => "HERMES_ENABLE_DEBUGGER=1" }
ss.dependency "RCT-Folly/Futures"
ss.dependency "hermes-engine"
end

s.subspec "DevSupport" do |ss|
ss.source_files = "React/DevSupport/*.{h,mm,m}",
"React/Inspector/*.{h,mm,m}"
Expand Down
2 changes: 1 addition & 1 deletion React/Base/RCTVersion.m
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
__rnVersion = @{
RCTVersionMajor: @(0),
RCTVersionMinor: @(66),
RCTVersionPatch: @(0),
RCTVersionPatch: @(4),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll want to undo this in main, which I guess my other review does.

RCTVersionPrerelease: [NSNull null],
};
});
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ - (instancetype)initWithSurface:(id<RCTSurfaceProtocol>)surface
[self _updateViews];

// For backward compatibility with RCTRootView, set a color here instead of transparent (OS default).
self.backgroundColor = [RCTUIColor whiteColor];
self.backgroundColor = [RCTUIColor whiteColor]; // TODO(macOS GH#774)
}

return self;
Expand Down
10 changes: 10 additions & 0 deletions React/CoreModules/RCTDevSettings.h
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,16 @@

@end

@protocol RCTDevSettingsInspectable <NSObject>

/**
* Whether current jsi::Runtime is inspectable.
* Only set when using as a bridgeless turbo module.
*/
@property (nonatomic, assign, readwrite) BOOL isInspectable;

@end

@interface RCTDevSettings : RCTEventEmitter <RCTInitializing>

- (instancetype)initWithDataSource:(id<RCTDevSettingsDataSource>)dataSource;
Expand Down
Loading