Correctly bypass sync calls in UIManager during remote debugging #92
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please select one of the following
Description of changes
(Mirroring facebook#25162)
Remote debugging stopped working (since 0.58, according to facebook#23254). See facebook#23254 (comment) for repro steps.
The root cause is incorrect checks for Chrome debugging environment in
UIManager.js
.lazilyLoadView
should be avoided, we effectively useif (__DEV__ && !global.nativeCallSyncHook)
to check remote debugging, which misses ship flavor (i.e.__DEV__
is false).getConstantsForViewManager
,if (__DEV__)
is used, also missing ship flavor.This PR fixes both checks, only using the absense of
global.nativeCallSyncHook
to determine remote debugging environments.Focus areas to test
(optional)
Microsoft Reviewers: Open in CodeFlow